Skip to content

React 19 upgrade for component library #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricksmith130 wants to merge 8 commits into from
Closed

React 19 upgrade for component library #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d7df7ae
updating compoment library to react 19
Aug 26, 2025
fc712eb
remove all react 16v
ricksmith130 Aug 27, 2025
f961cce
added back react testing
ricksmith130 Aug 27, 2025
6cb9f73
removed lock file
ricksmith130 Aug 27, 2025
d827365
removed yarn lock file
ricksmith130 Aug 27, 2025
30119a5
added back yarn lock
ricksmith130 Aug 27, 2025
ce0e719
moved deps to dev deps
ricksmith130 Aug 28, 2025
30c4dde
moved to peer deps
ricksmith130 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 32 additions & 65 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,95 +1,62 @@
{
"name": "nhsuk-react-components",
"version": "5.0.0",
"author": {
"name": "NHS England"
},
"files": [
"dist",
"lib"
],
"files": ["dist", "lib"],
"main": "dist/cjs/index.js",
"module": "dist/esm",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}
},
"sideEffects": false,
"scripts": {
"cleanup": "rm -rf dist/ > /dev/null && rm -rf lib/ > /dev/null",
"storybook": "storybook dev -p 6006",
"cleanup": "rm -rf dist/ lib/ >/dev/null 2>&1 || true",
"build": "yarn cleanup && rollup -c",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build",
"test": "jest",
"test:watch": "jest --watch",
"test:ci": "jest --coverage",
"lint": "eslint 'src/**/*.{js,ts,tsx}' 'stories/**/*.{js,ts,tsx}'",
"lint:fix": "eslint 'src/**/*.{js,ts,tsx}' 'stories/**/*.{js,ts,tsx}' --fix",
"lint:ci": "eslint 'src/**/*.{js,ts,tsx}' 'stories/**/*.{js,ts,tsx}'",
"build-storybook": "storybook build",
"prepublishOnly": "yarn lint:ci && yarn test:ci && yarn storybook --smoke-test"
},
"license": "MIT",
"peerDependencies": {
"react": "^19.0.0",
"react-dom": "^19.0.0"
},
"devDependencies": {
"react": "^19.1.1",
"react-dom": "^19.1.1",

"@babel/core": "^7.24.1",
"@babel/plugin-transform-modules-commonjs": "^7.23.3",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-terser": "^0.4.4",
"@rollup/plugin-typescript": "^11.1.6",
"@storybook/addon-actions": "^8.0.5",
"@storybook/addon-essentials": "^8.0.5",
"@storybook/addon-links": "^8.0.5",
"@storybook/blocks": "^8.0.5",
"@storybook/manager-api": "^8.0.5",
"@storybook/preview-api": "^8.0.5",
"rollup": "^4.13.0",
"rollup-plugin-dts": "^6.1.0",
"rollup-plugin-peer-deps-external": "^2.2.4",

"@storybook/react": "^8.0.5",
"@storybook/react-vite": "^8.0.5",
"@storybook/addon-essentials": "^8.0.5",
"@storybook/theming": "^8.0.5",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@types/babel__core": "^7",
"@types/jest": "^29.5.12",
"@types/jest-axe": "^3.5.9",
"@types/node": "^15.0.2",

"@testing-library/react": "^16.3.0",
"@types/react": "^18.2.60",
"@types/react-dom": "^18.2.19",
"@types/rollup-plugin-peer-deps-external": "^2.2.1",
"@typescript-eslint/eslint-plugin": "^7.1.0",
"@typescript-eslint/parser": "^7.1.0",
"babel-jest": "^29.7.0",
"chromatic": "^6.17.3",
"eslint": "^8.57.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"jest": "^29.7.0",
"jest-axe": "^8.0.0",
"jest-environment-jsdom": "^29.7.0",
"nhsuk-frontend": "^9.0.1",
"prettier": "^3.2.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"regenerator-runtime": "^0.13.7",
"rollup": "^4.13.0",
"rollup-plugin-dts": "^6.1.0",
"rollup-plugin-peer-deps-external": "^2.2.4",
"rollup-plugin-preserve-directives": "^0.4.0",
"rollup-plugin-tsconfig-paths": "^1.5.2",
"sass": "^1.53.0",
"storybook": "^8.0.5",
"ts-jest": "^29.1.2",

"typescript": "5.3.3",
"vite": "^4.5.3",
"vite-tsconfig-paths": "^4.3.2"
},
"dependencies": {
"classnames": "^2.2.6"
},
"peerDependencies": {
"nhsuk-frontend": ">=9.0.0 <10.0.0",
"react": ">=16.8.0",
"react-dom": ">=16.8.0"
Comment on lines -91 to -92
Copy link
Collaborator

@colinrotherham colinrotherham Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @ricksmith130

Do you know why we need to remove the peerDependency ranges here?

For the benefit of npm install nhsuk-react-components I'd rather we bumped the version ranges (instead of removing them) so npm can automatically install or verify you've got the correct version locally

"vite-tsconfig-paths": "^4.3.2",
"nhsuk-frontend": "^9.0.1",
"sass": "^1.53.0"
},
"license": "MIT",
"packageManager": "yarn@4.1.1"
}
Loading
Loading