Closed
Conversation
Comment on lines
-91
to
-92
| "react": ">=16.8.0", | ||
| "react-dom": ">=16.8.0" |
Collaborator
There was a problem hiding this comment.
Thanks for opening this PR @ricksmith130
Do you know why we need to remove the peerDependency ranges here?
For the benefit of npm install nhsuk-react-components I'd rather we bumped the version ranges (instead of removing them) so npm can automatically install or verify you've got the correct version locally
package.json
Outdated
Comment on lines
87
to
89
| "@testing-library/dom": "^10.4.1", | ||
| "classnames": "^2.2.6", | ||
| "lodash": "^4.17.21" |
Collaborator
There was a problem hiding this comment.
The two new packages should have been saved as devDependencies?
Thanks for spotting lodash was missing from .storybook/manager.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upgrade to react 19 - this is a blocker to mfe migrations