Skip to content

NetCDF Provider: Report file path in unit conversion exception (NGWPC-7604) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaynard-ngwpc merged 4 commits into from
Sep 16, 2025
Merged

NetCDF Provider: Report file path in unit conversion exception (NGWPC-7604) #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a89495
Remove catchment_id from string construction. Not available in method.
cmaynard-ngwpc Sep 16, 2025
faae425
NetCDF Provider: Reformat constructor initialization
PhilMiller Sep 16, 2025
3d0b897
NetCDF Provider: Store file path for later use in logging and error r…
PhilMiller Sep 16, 2025
54eca65
NetCDF Provider: Report file path in unit conversion exception
PhilMiller Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/forcing/NetCDFPerFeatureDataProvider.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ namespace data_access
TimeUnit time_unit; // the unit that time was stored as in the file
double time_stride; // the amount of time between stored time values
utils::StreamHandler log_stream;

std::string file_path;

std::shared_ptr<netCDF::NcFile> nc_file;

Expand Down
11 changes: 7 additions & 4 deletions src/forcing/NetCDFPerFeatureDataProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,12 @@ void NetCDFPerFeatureDataProvider::cleanup_shared_providers()
shared_providers.clear();
}

NetCDFPerFeatureDataProvider::NetCDFPerFeatureDataProvider(std::string input_path, time_t sim_start, time_t sim_end, utils::StreamHandler log_s) : log_stream(log_s), value_cache(20),
sim_start_date_time_epoch(sim_start),
sim_end_date_time_epoch(sim_end)
NetCDFPerFeatureDataProvider::NetCDFPerFeatureDataProvider(std::string input_path, time_t sim_start, time_t sim_end, utils::StreamHandler log_s)
: log_stream(log_s)
, file_path(input_path)
, value_cache(20)
, sim_start_date_time_epoch(sim_start)
, sim_end_date_time_epoch(sim_end)
{
//size_t sizep = 1073741824, nelemsp = 202481;
//float preemptionp = 0.75;
Expand Down Expand Up @@ -420,7 +423,7 @@ double NetCDFPerFeatureDataProvider::get_value(const CatchmentAggrDataSelector&
catch (const std::runtime_error& e)
{
data_access::unit_conversion_exception uce(e.what());
uce.provider_model_name = "NetCDFPerFeatureDataProvider " + catchment_id;
uce.provider_model_name = "NetCDFPerFeatureDataProvider(" + file_path + ")";
uce.provider_bmi_var_name = selector.get_variable_name();
uce.provider_units = native_units;
uce.unconverted_values.push_back(rvalue);
Expand Down
Loading