Skip to content

Comments

NetCDF Provider: Report file path in unit conversion exception (NGWPC-7604)#39

Merged
cmaynard-ngwpc merged 4 commits intorelease-candidatefrom
PhilMiller-7604-netcdf-followup
Sep 16, 2025
Merged

NetCDF Provider: Report file path in unit conversion exception (NGWPC-7604)#39
cmaynard-ngwpc merged 4 commits intorelease-candidatefrom
PhilMiller-7604-netcdf-followup

Conversation

@PhilMiller
Copy link

@PhilMiller PhilMiller commented Sep 16, 2025

Report on unit conversion errors from the NetCDF provider in full, so users can see where the source units came from

Additions

  • NetCDF Provider: store the provided file path for later use

Changes

  • NetCDF Provider: replace mistaken copy-paste catchment_id with file_path
  • Reformat the constructor arguments for clarity

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@cmaynard-ngwpc cmaynard-ngwpc marked this pull request as ready for review September 16, 2025 17:44
@cmaynard-ngwpc
Copy link

Built and ran locally in AWS Workspace. Verified new error messages are in ngen.log. Merging before pipeline is complete so it can be deployed in a more timely manner.

@cmaynard-ngwpc cmaynard-ngwpc merged commit b587aa2 into release-candidate Sep 16, 2025
6 of 22 checks passed
@cmaynard-ngwpc cmaynard-ngwpc deleted the PhilMiller-7604-netcdf-followup branch September 16, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants