Canonicalize -Preset,-Configuration; wildcard support#63
Merged
MarkSchofield merged 1 commit intodevelopfrom Sep 22, 2025
Merged
Canonicalize -Preset,-Configuration; wildcard support#63MarkSchofield merged 1 commit intodevelopfrom
MarkSchofield merged 1 commit intodevelopfrom
Conversation
MarkSchofield
temporarily deployed
to
General
GitHub Actions
Inactive
MarkSchofield
force-pushed
the
mschofie/parameter-names
branch
from
77d3983 to
01d6efe
Compare
MarkSchofield
temporarily deployed
to
General
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.
Configure-CMakeBuildandBuild-CMakeBuildhave inconsistent parameters withInvoke-CMakeOutput- they use the plural-Presets,-Configurationsand-Targets. This makes it awkward to use the same parameters betweenBuild-CMakeBuildandInvoke-CMakeOutputand - more importantly - it's against the 'Strongly Encouraged Development Guidelines' for PowerShell, which states that only parameters that are required to accept multiple values should have a plural name. This PR fixes the parameter names - keeping an 'Alias' for backward compatibility. Whilst re-working things, I also added 'wildcard' support for 'Configuration' and 'Preset' values.Whilst this change adds some tests, there's more to add. And more documentation is forthcoming.