Improve tests for Build-CMakeBuild and Configure-CMakeBuild#70
Merged
MarkSchofield merged 2 commits intodevelopfrom Oct 6, 2025
Merged
Improve tests for Build-CMakeBuild and Configure-CMakeBuild#70MarkSchofield merged 2 commits intodevelopfrom
MarkSchofield merged 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more test coverage for Build-CMakeBuild and Configure-CMakeBuild. This did uncover a regression between #63 and #67 - specifying an invalid preset or configuration is no longer an error. When a Preset is passed, all CMakePreset.json presets that match it are chosen. So if nothing matches then no presets are added, and nothing is run. If nothing matches, we now include the originally provided value to either: