-
Notifications
You must be signed in to change notification settings - Fork 0
Update basic examples to Light SDK 0.22 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,27 @@ | ||
| # Dependencies | ||
| **/node_modules/ | ||
| **/dist/ | ||
|
|
||
| # Environment and secrets | ||
| **/.env | ||
| **/.env.* | ||
| **/*-keypair.json | ||
| **/id.json | ||
|
|
||
| # Build artifacts | ||
| **/target | ||
| **/.anchor | ||
|
|
||
| # Test artifacts | ||
| **/test-ledger | ||
|
|
||
| # Lock files | ||
| **/pnpm-lock.yaml | ||
| **/package-lock.json | ||
|
|
||
| # Backups | ||
| **/*.json.bak | ||
| **/test-ledger | ||
| **/target | ||
| cli/accounts | ||
| README.html | ||
| README_files/ | ||
|
|
||
| **/.surfpool | ||
| .surfpool | ||
| # Project-specific | ||
| cli/accounts/ | ||
| bugs.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Missing
node-versioninput declaration makes custom Node.js setup unreachableThe composite action references
inputs.node-versionin conditionals on lines 36 and 42, and uses it as a value on line 39, butnode-versionis never declared in theinputs:section (.github/actions/setup/action.yml:4-23). In GitHub Actions composite actions, an undeclared input always evaluates to empty string.Root Cause and Impact
Because
inputs.node-versionis always'':if: inputs.node-version != ''→ always false → the "Setup Node.js" step never runsif: inputs.node-version == ''→ always true → the fallback "Setup Node.js (for Light CLI)" step always runs with hardcoded node 22This means any future caller passing
node-versionto this action will have it silently ignored (GitHub Actions warns about unexpected inputs but does not fail). The intended flexibility to configure a custom Node.js version is completely non-functional.The fix is to add
node-versionto theinputs:block withrequired: falseand an empty default.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.