Skip to content

Update basic examples to Light SDK 0.22#27

Merged
tilo-14 merged 1 commit intomainfrom
pr/basic-examples
Feb 18, 2026
Merged

Update basic examples to Light SDK 0.22#27
tilo-14 merged 1 commit intomainfrom
pr/basic-examples

Conversation

@tilo-14
Copy link
Contributor

@tilo-14 tilo-14 commented Feb 18, 2026

  • Bump all Light Protocol deps from 0.19/0.4 to 0.22
  • Bump Solana SDK from 2.2 to 2
  • Update CI setup action (Solana 2.3.11, Rust 1.90.0, caching)
  • Adapt basic-macros and create-and-transfer to new SDK API

Open with Devin

- Bump all Light Protocol deps from 0.19/0.4 to 0.22
- Bump Solana SDK from 2.2 to 2
- Update CI setup action (Solana 2.3.11, Rust 1.90.0, caching)
- Adapt basic-macros and create-and-transfer to new SDK API
@tilo-14 tilo-14 merged commit ecfa954 into main Feb 18, 2026
6 of 18 checks passed
@tilo-14 tilo-14 deleted the pr/basic-examples branch February 18, 2026 00:49
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment on lines +36 to +39
if: inputs.node-version != ''
uses: actions/setup-node@v4
with:
node-version: "22"
node-version: ${{ inputs.node-version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing node-version input declaration makes custom Node.js setup unreachable

The composite action references inputs.node-version in conditionals on lines 36 and 42, and uses it as a value on line 39, but node-version is never declared in the inputs: section (.github/actions/setup/action.yml:4-23). In GitHub Actions composite actions, an undeclared input always evaluates to empty string.

Root Cause and Impact

Because inputs.node-version is always '':

  • Line 36: if: inputs.node-version != '' → always false → the "Setup Node.js" step never runs
  • Line 42: if: inputs.node-version == '' → always true → the fallback "Setup Node.js (for Light CLI)" step always runs with hardcoded node 22

This means any future caller passing node-version to this action will have it silently ignored (GitHub Actions warns about unexpected inputs but does not fail). The intended flexibility to configure a custom Node.js version is completely non-functional.

The fix is to add node-version to the inputs: block with required: false and an empty default.

Prompt for agents
In .github/actions/setup/action.yml, add a `node-version` input declaration to the `inputs:` block (around line 5-23). It should be optional with an empty default, for example:

  node-version:
    description: "Node.js version (leave empty for default 22)"
    required: false
    default: ""

This should be added alongside the other input declarations (e.g., after `photon-indexer` around line 23) so that the conditional logic on lines 36 and 42 that references `inputs.node-version` actually works as intended.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments