Conversation
- Bump all Light Protocol deps from 0.19/0.4 to 0.22 - Bump Solana SDK from 2.2 to 2 - Update CI setup action (Solana 2.3.11, Rust 1.90.0, caching) - Adapt basic-macros and create-and-transfer to new SDK API
| if: inputs.node-version != '' | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "22" | ||
| node-version: ${{ inputs.node-version }} |
There was a problem hiding this comment.
🟡 Missing node-version input declaration makes custom Node.js setup unreachable
The composite action references inputs.node-version in conditionals on lines 36 and 42, and uses it as a value on line 39, but node-version is never declared in the inputs: section (.github/actions/setup/action.yml:4-23). In GitHub Actions composite actions, an undeclared input always evaluates to empty string.
Root Cause and Impact
Because inputs.node-version is always '':
- Line 36:
if: inputs.node-version != ''→ always false → the "Setup Node.js" step never runs - Line 42:
if: inputs.node-version == ''→ always true → the fallback "Setup Node.js (for Light CLI)" step always runs with hardcoded node 22
This means any future caller passing node-version to this action will have it silently ignored (GitHub Actions warns about unexpected inputs but does not fail). The intended flexibility to configure a custom Node.js version is completely non-functional.
The fix is to add node-version to the inputs: block with required: false and an empty default.
Prompt for agents
In .github/actions/setup/action.yml, add a `node-version` input declaration to the `inputs:` block (around line 5-23). It should be optional with an empty default, for example:
node-version:
description: "Node.js version (leave empty for default 22)"
required: false
default: ""
This should be added alongside the other input declarations (e.g., after `photon-indexer` around line 23) so that the conditional logic on lines 36 and 42 that references `inputs.node-version` actually works as intended.
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.