-
Notifications
You must be signed in to change notification settings - Fork 5
added new error handling to date and datetime #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oroth8
wants to merge
8
commits into
main
Choose a base branch
from
return-decanter-exception-for-date-and-datetime-formating-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e8d994
added new error handling to date and datetime
oroth8 82e49c5
added more tests
oroth8 8e36442
raise based on message
oroth8 f4cd054
refactor rescue to still raise an argument error even though it is no…
oroth8 b5333ea
bump minor version
oroth8 217ffe7
Merge branch 'main' into return-decanter-exception-for-date-and-datet…
oroth8 7e69ed1
rescue Date::Error instead and make sure errors are not swallowed
oroth8 99304cc
bump version to 5.1.0
oroth8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,22 @@ | ||
| module Decanter | ||
| module Parser | ||
| class DateParser < ValueParser | ||
|
|
||
| allow Date | ||
|
|
||
| parser do |val, options| | ||
| next if (val.nil? || val === '') | ||
| raise Decanter::ParseError, 'Expects a single value' if val.is_a? Array | ||
| next if val.nil? || val === '' | ||
| parse_format = options.fetch(:parse_format, '%m/%d/%Y') | ||
| ::Date.strptime(val, parse_format) | ||
| begin | ||
| ::Date.strptime(val, parse_format) | ||
| rescue Date::Error => e | ||
| if e.message == 'invalid date' | ||
| raise Decanter::ValueFormatError, 'invalid Date value for format' | ||
| else | ||
| raise Decanter::ValueFormatError, e.message | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module Decanter | ||
| VERSION = '5.0.0'.freeze | ||
| VERSION = '5.1.0'.freeze | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latest from |
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line can be removed since this parser inherits from
ValueParser, which raises an error if the value is an array