added new error handling to date and datetime #133
Conversation
chawes13
left a comment
chawes13
left a comment
There was a problem hiding this comment.
Can you bump the version number as well?
bumped the minor version number |
chawes13
left a comment
chawes13
left a comment
There was a problem hiding this comment.
Sorry for the radio silence 📻 🫣. A few comments regarding some design choices, but overall super close!
nicoledow
left a comment
nicoledow
left a comment
There was a problem hiding this comment.
Sorry for the wait on this. I thought there were changes requested, but I was mistaken!
This looks and works great, just left a couple minor questions.
| @@ -1,3 +1,3 @@ | |||
| module Decanter | |||
| VERSION = '5.0.0'.freeze | |||
| VERSION = '5.1.0'.freeze | |||
There was a problem hiding this comment.
The latest from main may need to be pulled in here - we're at 5.1.0 now so this can be bumped up to 5.2.0
|
|
||
| parser do |val, options| | ||
| next if (val.nil? || val === '') | ||
| raise Decanter::ParseError, 'Expects a single value' if val.is_a? Array |
There was a problem hiding this comment.
I think this line can be removed since this parser inherits from ValueParser, which raises an error if the value is an array
Items Addressed
feature request
Decanter::ValueFormatError '(invalid (Date/DateTime) value for format'