Skip to content

Callback properties #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcemira wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Callback properties #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb14fc7
Merge pull request #1 from K-Phoen/master
marcemira Mar 21, 2016
770b76b
Property aware callbacks
marcemira Mar 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Listener/AbstractSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function onSetInitialState(StateMachineEvent $event)
public function onTestTransition(TransitionEvent $event)
{
$object = $event->getStateMachine()->getObject();
$result = $this->callCallback($object, 'can', $event->getTransition()->getName());
$result = $this->callCallback($object, 'can', $event);
Copy link
Owner

@K-Phoen K-Phoen Apr 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BC-break here :)

Copy link
Contributor Author

@marcemira marcemira Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello K-Phoen! Can you please explain a little bit more? Can tell where's the BC-break here. I'm not using that callback on my current use case, so I might have miss something :/


if ($result === false) {
$event->reject();
Expand All @@ -68,13 +68,13 @@ public function onTestTransition(TransitionEvent $event)
public function onPreTransition(TransitionEvent $event)
{
$object = $event->getStateMachine()->getObject();
$this->callCallback($object, 'pre', $event->getTransition()->getName());
$this->callCallback($object, 'pre', $event);
}

public function onPostTransition(TransitionEvent $event)
{
$object = $event->getStateMachine()->getObject();
$this->callCallback($object, 'post', $event->getTransition()->getName());
$this->callCallback($object, 'post', $event);
}

/**
Expand All @@ -85,8 +85,9 @@ public function onPostTransition(TransitionEvent $event)
* @param string $transitionName
* @return mixed
*/
protected function callCallback($object, $callbackPrefix, $transitionName)
protected function callCallback($object, $callbackPrefix, $event)
{
$transitionName = is_string($event) ? 'initialize' : $event->getTransition()->getName();
$camelCasedName = Inflector::camelize($transitionName);
$methodName = $callbackPrefix . $camelCasedName;

Expand All @@ -98,6 +99,6 @@ protected function callCallback($object, $callbackPrefix, $transitionName)
return;
}

return call_user_func(array($this, $methodName), $object);
return call_user_func(array($this, $methodName), $object, $event->getProperties());
}
}