Callback properties #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request K-Phoen#20 from marcemira/master
Now every callback has access to same properties as can method. This allow the possibility of bringing context to transition callbacks.
Owner
|
This PR can not be merged as-is: it would break backward compatibility. |
| { | ||
| $object = $event->getStateMachine()->getObject(); | ||
| $result = $this->callCallback($object, 'can', $event->getTransition()->getName()); | ||
| $result = $this->callCallback($object, 'can', $event); |
Contributor
Author
There was a problem hiding this comment.
Hello K-Phoen! Can you please explain a little bit more? Can tell where's the BC-break here. I'm not using that callback on my current use case, so I might have miss something :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.