-
Notifications
You must be signed in to change notification settings - Fork 0
[REFACTOR] 전체 페이지 리팩토링 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Whatdoyumin
wants to merge
54
commits into
develop
Choose a base branch
from
refactor/all-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
7ae36c4
✨ feat: 알람 컴포넌트에서 라우팅 경로 수정
Whatdoyumin 8e4d21c
✨ feat: 쿼리 라우팅 추가
Whatdoyumin e3697ef
✨ feat: 버튼 수정
Whatdoyumin b577c2c
💄 style: 높이 뷰포트 기준으로 수정
Whatdoyumin e058281
✨ feat: 본인 인증 alert 수정
Whatdoyumin 6e8f109
✨ feat: 이미지 슬라이드 추가
Whatdoyumin 1222702
✨ feat: 상세 정보 월세일 경우 표시 수정
Whatdoyumin 763b107
✨ feat: homeId 쿼리 API 요청으로 추가
Whatdoyumin f467320
✨ feat: 매물 등록 alert 추가
Whatdoyumin 3dd6beb
✨ feat: 주석 삭제
Whatdoyumin 97b965d
♻ refactor: 계약서 채팅 오류 수정
Whatdoyumin 056b796
♻ refactor: 로딩 처리
Whatdoyumin 42b52d7
♻ refactor: 기본값 수정
Whatdoyumin 8d6122b
Merge branch 'develop' of https://github.com/ITZEEP/frontend into ref…
Whatdoyumin 3fc0cb6
✨ feat: 웹 소켓 수정
Whatdoyumin ecea430
✨ feat: 4단계 최종 계약서 확정 후 내보내기 페이지로 라우팅
Whatdoyumin 29f27c7
🌱 chore: Merge develop
Whatdoyumin c0eb97e
✨ feat: 메인 페이지 캐릭터 애니메이션 추가
Whatdoyumin 2107d89
🐛 fix: 웹 소켓 수정
Whatdoyumin dc666f1
✨ feat: 내가 보낸 버튼 비활성화
Whatdoyumin d712614
:bug: fix: solve conflict
MeongW 685b3bc
:bug: fix: 다 수정 해버릴거야
MeongW efe799f
🐛 fix: 임대인 로딩 처리 수정
Whatdoyumin 22fc56e
:bug: fix: 죄송한커밋
MeongW aa4404b
Merge branch 'refactor/all-ui' of https://github.com/ITZEEP/frontend …
MeongW 86cda14
✨ feat: 최종 계약서 다운로드 1회 제한
Whatdoyumin 37f032d
💄 style: div 색상 수정
Whatdoyumin 8a5b4f4
✨ feat: username과 인사말 표시
Whatdoyumin 6080a10
✨ feat: 실명인증 확인 표시 추가
Whatdoyumin 7df0d1f
✨ feat: 마이페이지 계약서 내역 확인 추가
Whatdoyumin 225aa64
✨ feat: 계약 채팅방 바로가기 버튼은 클릭 가능하게 수정
Whatdoyumin cf46c1a
✨ feat: 일반 채팅 뷰포트 수정
Whatdoyumin de17476
🐛 fix: 버튼 오류 삭제
Whatdoyumin a9fb14d
✨ feat: 안내 멘트 추가
Whatdoyumin be9b6a4
✨ feat: 수락/거절 시 alert 추가
Whatdoyumin abbd48c
✨ feat: 기본 특약 검토 버튼 삭제
Whatdoyumin 6de88e9
:bug: fix: UI 개선
MeongW 27562a6
:bug: fix: 일부 UI 수정
MeongW d3b770b
Merge branch 'refactor/all-ui' of https://github.com/ITZEEP/frontend …
MeongW 7601267
✨ feat: 주소 추가
Whatdoyumin 489c35f
✨ feat: 로그인 버튼으로 변경
Whatdoyumin 6d6279d
💄 style: 마지막 디자인 수정
MeongW 2cc1068
♻ refactor: 특약 검토 버튼 추가
Whatdoyumin ee310a0
✨ feat: 참여자 명단 추가
Whatdoyumin 9c8c1d1
Merge branch 'refactor/all-ui' of https://github.com/ITZEEP/frontend …
Whatdoyumin 6c56879
:bug: fix: 일부 수정
MeongW 2d112f2
Merge branch 'refactor/all-ui' of https://github.com/ITZEEP/frontend …
MeongW 271d601
:bug: fix: 일부 수정
MeongW 978889b
💄 style: 색상 변경
Whatdoyumin d027be2
✨ feat: 문구 변경
Whatdoyumin d8da1d3
✨ feat: 적법성 확인 메시지 디자인 추가
Whatdoyumin b42c6ff
:sparkles: feat: 모바일 지원
MeongW b67c641
Merge branch 'refactor/all-ui' of https://github.com/ITZEEP/frontend …
MeongW 6d402a4
:bug: fix: 일부 수정
MeongW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # API 설정 | ||
| VITE_API_BASE_URL=http://localhost:8080 | ||
| VITE_WS_URL=ws://localhost:8080 | ||
|
|
||
| # Kakao OAuth | ||
| VITE_KAKAO_JAVASCRIPT_KEY=your_kakao_key_here | ||
|
|
||
| # Firebase FCM | ||
| VITE_FIREBASE_API_KEY=AIzaSyCoYr1H2VwJaLpHA0krtZCOX-dTDGlXZYM | ||
| VITE_FIREBASE_AUTH_DOMAIN=itzeep-de0ca.firebaseapp.com | ||
| VITE_FIREBASE_PROJECT_ID=itzeep-de0ca | ||
| VITE_FIREBASE_STORAGE_BUCKET=itzeep-de0ca.firebasestorage.app | ||
| VITE_FIREBASE_MESSAGING_SENDER_ID=966020195845 | ||
| VITE_FIREBASE_APP_ID=1:966020195845:web:9532cf29ef4f7108d55e6c | ||
| VITE_FIREBASE_MEASUREMENT_ID=G-4MWDC6FYCE | ||
| VITE_FIREBASE_VAPID_KEY=BBwhqrm3fd9077YciPjcCv1H7E1rrEbfIko3CwjtE4PlpkY-3PGnV0V1TBUAU_epvIP9ug_ktwaDvxQsYAQobk0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,36 @@ | ||
| <script setup> | ||
| import { RouterView } from 'vue-router' | ||
| import DefaultLayout from './components/layouts/DefaultLayout.vue' | ||
| import LoginModal from './components/common/LoginModal.vue' | ||
| import ConfirmModal from './components/common/ConfirmModal.vue' | ||
| import { useLoginModal } from '@/composables/useLoginModal' | ||
| import { useConfirmModal } from '@/composables/useConfirmModal' | ||
|
|
||
| const { isLoginModalOpen, redirectPath, closeLoginModal } = useLoginModal() | ||
| const { isConfirmModalOpen, confirmTitle, confirmMessage, handleConfirm, handleCancel } = useConfirmModal() | ||
| </script> | ||
|
|
||
| <template> | ||
| <DefaultLayout> | ||
| <RouterView /> | ||
| </DefaultLayout> | ||
|
|
||
| <!-- 전역 로그인 모달 --> | ||
| <LoginModal | ||
| v-model="isLoginModalOpen" | ||
| :redirect-path="redirectPath" | ||
| @cancel="closeLoginModal" | ||
| @confirm="closeLoginModal" | ||
| /> | ||
|
|
||
| <!-- 전역 확인 모달 --> | ||
| <ConfirmModal | ||
| :is-open="isConfirmModalOpen" | ||
| :title="confirmTitle" | ||
| :message="confirmMessage" | ||
| @confirm="handleConfirm" | ||
| @cancel="handleCancel" | ||
| /> | ||
| </template> | ||
|
|
||
| <style scoped></style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
getExportStatus: 에러 시 null 반환으로 변경 — 호출부 영향 점검 및 반환 형태 문서화/표준화 권장
이번 변경으로 성공이 아니면 null을 반환하게 되었습니다. 폴링 기반 처리에는 합리적이지만, 기존 호출부가 객체 형태(예: { success, data })를 기대했다면 런타임 오류를 유발할 수 있습니다. 최소한 호출부에서 null 체크가 모두 되어있는지 확인 부탁드립니다. 또한 이 파일 내 다른 API들이 반환하는 형태가 제각각이라(일부는 result, 일부는 result.data, 일부는 null), 일관된 Result 형태로 표준화하는 것을 권장합니다.
아래 스크립트로 getExportStatus 호출부에서 null 체크가 누락된 곳을 빠르게 살펴볼 수 있습니다.
선택지:
옵션 B(표준화) 최소 패치 예시:
🏁 Script executed:
Length of output: 1254
🏁 Script executed:
Length of output: 1686
getExportStatus 폴링 로직에 null 처리 누락으로 인한 런타임 오류 가능 – 즉시 수정 필요
폴링 루프에서
getExportStatus가null을 반환할 경우, 아래 코드에서status.isCompleted등을 읽으면서 예외가 발생합니다. 초기 호출부에는 null 체크(if (initialStatus))가 되어 있으나, 폴링 구간에는 빠져 있습니다.수정 방안 (택1):
exportStatus.value = status
if ((status.isCompleted || status.completed) && status.finalPdfUrl) { … }
{ success, data })status.success로 검사하도록 일관화.또한,
getExportStatus함수에 JSDoc/타입 정의로 null 반환 가능 여부를 명확히 문서화해 주세요.🤖 Prompt for AI Agents