Splitting the option for -shared and setting a soname (library path)#138
Closed
inkdot7 wants to merge 4 commits intoISOLDESolenoidalSpectrometer:mainfrom
Closed
Splitting the option for -shared and setting a soname (library path)#138inkdot7 wants to merge 4 commits intoISOLDESolenoidalSpectrometer:mainfrom
inkdot7 wants to merge 4 commits intoISOLDESolenoidalSpectrometer:mainfrom
Conversation
…, but also do not pass CI with permission error.
… To make it easier to remove soname option.
This was referenced Dec 6, 2025
Merged
Contributor
|
overtaken by changes in #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this commit is to make some version of #133 more straightforward to consider.
This commit in itself should not change how the library is build, it just splits the variable holding the arguments.
This is on top of #137 in order for CI to pass for the PR.