Update includeDeaccessioned to GetFile use case#322
Merged
ofahimIQSS merged 4 commits intodevelopfrom Jul 2, 2025
Merged
Conversation
github-actions
bot
added
FY25 Sprint 26
g-saracca
approved these changes
Jul 2, 2025
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
g-saracca
requested changes
Jul 2, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Sorry, I approved without seeing that tests are failing.
Contributor
Author
|
@g-saracca no worries, thanks for reviewing, I fixed tests so you could review again. |
g-saracca
reviewed
Jul 2, 2025
g-saracca
approved these changes
Jul 2, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Author
|
Hi Omer @ofahimIQSS , could you merge this PR ASAP please? Since we're about to publish the package of js-dataverse and want to include this change as well. Thank you!! |
Contributor
|
merged! thanks |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This was referenced Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to correctly get the file which is deaccessioned, we need include the includeDeaccessioned, so even though the dataset is deaccessioned, by applying includeDeaccessioned = true to the GETFile endpoint, the owner could get right response to access the deaccessioned file.
Which issue(s) this PR closes: