Update includedeaccessioned to GetFileById#766
Merged
ofahimIQSS merged 5 commits intodevelopfrom Jul 17, 2025
Merged
Conversation
Contributor
|
Hey! this one has branch conflicts - can i get an update please :) |
The merge-base changed after approval.
Contributor
|
@ChengShi-1 I think you didn't solve merge conflicts correctly, I see lot of unrelated changes and things removed we shouldn't remove. |
Contributor
Author
|
@g-saracca Yes, I need revert and merge again. solving |
80b386c to
948164f
Compare
Contributor
Author
|
@g-saracca Reset the branch and merge again, should be ok now. Thanks! (I falsely merged branch with discarding all changes from dev....sorry for that |
Contributor
That's ok, no need to be sorry 👍🏼 , waiting for tests to pass and will approve 🙂 |
g-saracca
approved these changes
Jul 16, 2025
Contributor
|
@ofahimIQSS all good now 👍🏼 |
Contributor
|
tested in local - no issues found. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Related to IQSS/dataverse-client-javascript#322
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
It's better to wait #741 to be merged to this PR and then test
As a superuser,
create dataset with a file and published dataset
deaccessioned dataset
click to the file table's file, in dataset page, so navigate to file page
see if the file page of deaccessioned version is ok, also should be shown with deaccessioned format

Log out (As a guest user
go the deaccessioned dataset(superuser created), the file deaccessioned version should not be shown(404 page expected
If there are other versions not deaccessioned, guest users should be accessed to other released/ non-deaccessioned versions, but the file > version tab should not attach links to deaccessioned version