Skip to content

return citationHtml instead of citation plain text#312

Merged
ofahimIQSS merged 2 commits intodevelopfrom
311-citationHtml-property
Jun 2, 2025
Merged

return citationHtml instead of citation plain text#312
ofahimIQSS merged 2 commits intodevelopfrom
311-citationHtml-property

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Jun 2, 2025

What this PR does / why we need it:

This just returns citationHtml instead of citation (plain text) for the GetCollectionItems use case.
This is needed to correctly display the citation box in the Dataset Cards within the Collection Page.

Which issue(s) this PR closes:

How to test this?

Code review and check that tests are passing.

@github-actions github-actions bot added GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature labels Jun 2, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Jun 2, 2025
@ekraffmiller ekraffmiller self-assigned this Jun 2, 2025
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 2, 2025
ekraffmiller
ekraffmiller previously approved these changes Jun 2, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 2, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good, approving

@ofahimIQSS
Copy link
Contributor

tests are passing - merging

@ofahimIQSS ofahimIQSS merged commit 68315ed into develop Jun 2, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Jun 2, 2025
@ofahimIQSS ofahimIQSS deleted the 311-citationHtml-property branch June 2, 2025 19:25
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Add citationHTML property to dataset preview item

3 participants