return citationHtml instead of citation plain text#312
Merged
ofahimIQSS merged 2 commits intodevelopfrom Jun 2, 2025
Merged
Conversation
ekraffmiller
approved these changes
Jun 2, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
fix looks good, approving
Contributor
|
tests are passing - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This just returns citationHtml instead of citation (plain text) for the
GetCollectionItemsuse case.This is needed to correctly display the citation box in the Dataset Cards within the Collection Page.
Which issue(s) this PR closes:
How to test this?
Code review and check that tests are passing.