Conversation
| overflow: hidden; | ||
| font-size: $dv-font-size-sm; | ||
| background-color: color.adjust($dv-primary-color, $lightness: 51%); | ||
| border: solid 1px color.adjust($dv-primary-color, $lightness: 20%); |
There was a problem hiding this comment.
Yep, I've mentioned this in the PR description, what do you think about it? cc: @ekraffmiller
I've also added a border to citation boxes in dataset cards to contrast it better with the background, same for deaccessioned citation boxes.
tests/component/sections/collection/collection-items-panel/dataset-card/DatasetCard.spec.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/collection/collection-items-panel/file-card/FileCard.spec.tsx
Show resolved
Hide resolved
tests/component/sections/collection/collection-items-panel/file-card/FileCard.spec.tsx
Show resolved
Hide resolved
|
Thanks @ChengShi-1!
That should be fixed in this PR, because it was fixed in this js-dataverse PR that is merged already and this PR is using that version, could you try to install packages again? I can see dataset citations links on my end.
Dataset and File descriptions occupy 100% of the card width, for that they are place below as usually this cards have more information next to the icon/thumbnail. |
Hi @ofahimIQSS , yes, that's not implemented yet and there is already an open issue for that but it's not a priority right now. |
|
testing passed- merging PR |






What this PR does / why we need it:
We've identified some discrepancies and areas for improvement in the Collection page cards (collection,dataset and file cards). This effort will address visual fixes and adjust the underlying display logic for various elements.
Collection Card :
Dataset Card :
File Card :
Which issue(s) this PR closes:
Special notes for your reviewer:
For roles badges I changed it to use "info" variant because now we are using "success" variant for "In Review" status badges. JSF is using also info variant but it has a lighter blue.
I've also added a border to citation boxes in dataset cards to contrast it better with the background, same for deaccessioned citation boxes.
Suggestions on how to test this:
Step 1: Run the Development Environment
Step 2: Test the changes
Most of the changes here are about Collection, Dataset and File cards layout related. You can see if you are happy with the layout by looking at the stories, this for example is one of the CollectionCard stories, check also DatasetCard and FileCard stories.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: