-
Notifications
You must be signed in to change notification settings - Fork 10
DatasetValidator allow empty fields for conditionally required fields. #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
reviewed
Mar 25, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just 2 small things.
- I notice the internalVersion is an optional parameter from api, but it is set to be required in modal dataset.ts and datasetPayload.
- Some comments left here, not sure if you want them to be a guidance, or you want to remove them. If it is meant to be there, just ignore my comments there.
src/datasets/domain/useCases/validators/SingleMetadataFieldValidator.ts
Outdated
Show resolved
Hide resolved
ChengShi-1
approved these changes
Mar 26, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Contributor
|
Tests are passing, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
FY25 Sprint 18
FY25 Sprint 18 (2025-02-26 - 2025-03-12)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q1
Not related to any specific Q1 feature
SPA.Q1.6
Files Page: Files Edit Options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Modifies the Create/Update Dataset Validator to allow empty values in child fields that are required but their parent fields (compound fields) are not.
These child fields should only be truly required when one of their siblings fields has a value; otherwise, they can be left empty.
I have also added a new parameter to the
UpdateDatasetuse case which is theinternalVersionNumberof the dataset, and also now in theGetDatasetuse case we are returning that property to be used later.Integration tests were added 👍🏼 .
Which issue(s) this PR closes:
Related Dataverse PRs:
Suggestions on how to test this:
review code and unit tests