Edit Dataset Metadata: Dataset metadata fields couldn't set to empty result#631
Merged
ofahimIQSS merged 13 commits intodevelopfrom Apr 1, 2025
Merged
Edit Dataset Metadata: Dataset metadata fields couldn't set to empty result#631ofahimIQSS merged 13 commits intodevelopfrom
ofahimIQSS merged 13 commits intodevelopfrom
Conversation
Contributor
Author
|
@ChengShi-1 , ready for review 👍🏼 |
ChengShi-1
approved these changes
Mar 31, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Looks good. tested on my local environment, works well
Contributor
|
looking good, did further testing and didnt come across any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix an issue were empty values were ignored.
Now that related API work was done, we can send empty values while updating a dataset.
This PR does that, so you can send an empty value of a not required field which previously had value.
Important: we also introduce sending the dataset internal version number while updating a dataset, to avoid unwanted changes if updating and outdated dataset, I will add test cases for that.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
**Step 3: Test the new internal sourcer number validation.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No