FDTD Solver / Free Electron Laser for ALPINE by manuel5975p · Pull Request #289 · IPPL-framework/ippl

manuel5975p · 2024-05-05T18:57:28Z

Open questions

How to incorporate boundary conditions? They are incompatible with ippls BCType concept
Should Electrostatic and Electromagnetic Solvers implement the same interface?

Design

…nsforms

manuel5975p · 2024-05-24T15:50:21Z

Update: Now everything is in the /fel directory
I also added a matrix type in Types/Matrix. The lorentz transform classes depend on it.

aaadelmann · 2024-05-29T20:18:54Z

There are still a few open comments from Sonali to be addressed.

s-mayani · 2024-06-24T14:36:04Z

fel/FreeElectronLaser.cpp

+    /* Type of the bunch which is one of the manual, ellipsoid, cylinder, cube, and 3D-crystal. If
+     * it is manual the charge at points of the position vector will be produced.
+     */
+    // std::string     			bunchType_;


See previous comment: "why is this commented? not needed?"

s-mayani · 2024-06-24T14:36:22Z

fel/FreeElectronLaser.cpp

+    // std::vector<FieldVector<scalar> >	position_;
+    FieldVector<scalar> position_;
+
+    /* Number of macroparticles in each direction for 3Dcrystal type. */


see previous comment: this 3D crystal type thing is inherited from mithra I assume? is it actually supported here? if so I would add some explanation of what it means

s-mayani · 2024-06-24T14:37:08Z

fel/FreeElectronLaser.cpp

+        // printmessage(std::string(__FILE__), __LINE__, std::string("Warning: The number of
+        // particles in the bunch is not a multiple of four. ") +
+        //     std::string("It is corrected to ") +  std::to_string(bunchInit.numberOfParticles_) );


why is this commented? if not necessary, please remove

s-mayani · 2024-06-24T14:37:39Z

fel/FreeElectronLaser.cpp

+    /* Check the bunching factor. */
+    if (bunchInit.bF_ > 2.0 || bunchInit.bF_ < 0.0) {
+        // printmessage(std::string(__FILE__), __LINE__, std::string("The bunching factor can not be
+        // larger than one or a negative value !!!") ); exit(1);
+    }


this if is not doing anything

s-mayani · 2024-06-24T14:38:28Z

fel/FreeElectronLaser.cpp

+        // else
+        //   return  ( randomNumbers[ n * 2 * Np/ng + m ] );
+        // TODO: Return halton properly
+        // return 	( halton(n,m) );


why commented? if not needed, remove

s-mayani · 2024-06-24T14:40:02Z

fel/FreeElectronLaser.cpp

+        if (std::isnan(iterQ->rnp[2])) {
+            std::cerr << iterQ->gb[2] << ", " << g << ", " << iterQ->rnp[2] << ", " << bunch_.zu_
+                      << ", " << frame_beta << "\n";
+            std::cerr << __FILE__ << ": " << __LINE__ << "   OOOOOF\n";


this error message should be more informative

s-mayani · 2024-06-24T14:40:22Z

fel/FreeElectronLaser.cpp

+    for (auto iterQ = chargeVectorn_.begin(); iterQ != chargeVectorn_.end(); iterQ++) {
+        Double g = std::sqrt(1.0 + iterQ->gb.squaredNorm());
+        if (std::isinf(g)) {
+            std::cerr << __FILE__ << ": " << __LINE__ << " inf gb: " << iterQ->gb << ", g = " << g


this error message should be more informative, unless it's just there for debug purposes

fel/FreeElectronLaser.cpp

test/solver/TestFDTDSolverWithParticles.cpp

s-mayani · 2024-06-24T14:50:47Z

src/Types/Matrix.h

Where is this Matrix type used? Is this a replacement of the ippl::Vector<ippl::Vector<T,3>,3> type normally used as Matrix_t in the solvers?

Used in the struct LorenzFrame, which is not used anywhere in the code in fel.
Do we want this struct and this type in ippl?

s-mayani · 2024-06-24T14:51:46Z

src/MaxwellSolvers/FDTD.h

still needs to be divided into .h and .hpp, if we have decided to still go with that structure

Devided in to FDTDSolverBase, StandardFDTDSolver and NonStandardFDTDSolver, all with .h and .hpp file

s-mayani · 2024-06-25T06:15:38Z

fel/NSFDSolverWithParticles.h

+        // return pear<ippl::Vector<int, 3>, ippl::Vector<T, 3>>{ippl::Vector<int, 3>{5,5,5},
+        // ippl::Vector<T, 3>{0,0,0}}; printf("%.10e, %.10e, %.10e\n", (inverse_spacing *
+        // spacing)[0], (inverse_spacing * spacing)[1], (inverse_spacing * spacing)[2]);


commented stuff is just for debug purposes or necessary to keep?

s-mayani · 2024-06-25T06:16:00Z

fel/NSFDSolverWithParticles.h

+        for (unsigned k = 0; k < 3; k++) {
+            fracpos[k] = gridpos[k] - (int)ipos[k];
+        }
+        // TODO: NGHOST!!!!!!!


please make this TODO more informative

s-mayani · 2024-06-25T06:16:34Z

fel/NSFDSolverWithParticles.h

+        // printf("Scatterdest: %.4e, %.4e, %.4e\n", from_grid.second[0], from_grid.second[1],
+        // from_grid.second[2]);
+        for (int d = 0; d < 3; d++) {
+            // if(abs(from_grid.first[d] - to_grid.first[d]) > 1){
+            //     std::cout <<abs(from_grid.first[d] - to_grid.first[d]) << " violation " <<
+            //     from_grid.first << " " << to_grid.first << std::endl;
+            // }
+            // assert(abs(from_grid.first[d] - to_grid.first[d]) <= 1);
+        }
+        // const uint32_t nghost = g.nghost();
+        // from_ipos += ippl::Vector<int, 3>(nghost);
+        // to_ipos += ippl::Vector<int, 3>(nghost);


what is this doing? remove if not necessary anymore

s-mayani · 2024-06-25T06:18:11Z

fel/NSFDSolverWithParticles.h

add more comments in general

s-mayani · 2024-06-25T06:20:20Z

src/MaxwellSolvers/FDTD.h

+        FourField A_n;
+        FourField A_np1;
+        FourField A_nm1;
+        scalar dt;


Previous review comment still applies: Are these attributes supposed to be public?
It would also make the code more readable to have them at the end of the code block (like in the first public block you have the attributes at the end before the private).

These are protected variables in FDTDSolverBase now.

s-mayani · 2024-06-25T06:20:57Z

src/MaxwellSolvers/FDTD.h

+     * @tparam FourField
+     */
+    template <typename EMField, typename FourField, fdtd_bc boundary_conditions = periodic>
+    class NonStandardFDTDSolver : Maxwell<EMField, FourField> {


add more comments to this class / documentation

src/Particle/ParticleAttrib.hpp

s-mayani · 2024-06-25T06:26:03Z

fel/NSFDSolverWithParticles.h

+        return ret;
+    }
+    template <typename view_type, typename scalar>
+    KOKKOS_FUNCTION void scatterToGrid(const ippl::NDIndex<3>& ldom, view_type& view,


comment from previous review still applies: the scatter is repeated here and also in the FreeElectronLaser.cpp, would be nice to avoid this by putting it in some common file maybe.

srikrrish · 2025-05-07T05:26:17Z

I am done with my comments. But it seems this branch may still have some conflicts that need to be resolved.

manuel5975p added 25 commits April 13, 2024 14:45

FEL-IR-a works

b5c8668

Working on MPI

c8cb043

ABC working with mpi

2b25e72

timing

cfba362

Remove gathers

9da50c9

Custom output path

24ff0a6

Add useful radiation output

35f2d01

Correct radiation eval

0fbb69a

Correct now

eb553ce

Change colorscheme and labframe rad

120726d

FFMPEG output

ba073e6

Gauss test

200ad6d

Revert vector and particle attrib changes, make FDTD Solver compatible

3958ed8

Gauss and ampere

b45bd97

Add plotscripts

d8f7568

Some things

46ff0d9

Second order ABCs working

68b3111

Add Solver with particles

10495c7

Support for external fields

ae9472c

Particle solwer

a72e92f

ParticleAttribute: add custom reduction loop

c4ff276

fdtd particle test

fd86bdc

Hack gather routine

5731b7f

helper structs

427b5f7

FEL-IR working

059807a

manuel5975p requested review from aaadelmann, matt-frey, s-mayani and srikrrish May 5, 2024 18:57

manuel5975p self-assigned this May 5, 2024

Move FEL stuff to separate directory, add matrix type and lorentz tra…

7a803ac

…nsforms

Move Particle stuff into fel/

b0ba995

s-mayani self-requested a review June 24, 2024 14:24

s-mayani reviewed Jun 24, 2024

View reviewed changes

fel/FreeElectronLaser.cpp Outdated Show resolved Hide resolved

s-mayani reviewed Jun 24, 2024

View reviewed changes

test/solver/TestFDTDSolverWithParticles.cpp Show resolved Hide resolved

s-mayani reviewed Jun 24, 2024

View reviewed changes

s-mayani reviewed Jun 25, 2024

View reviewed changes

fel/NSFDSolverWithParticles.h

Copy link

Collaborator

s-mayani Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more comments in general

s-mayani reviewed Jun 25, 2024

View reviewed changes

src/Particle/ParticleAttrib.hpp Show resolved Hide resolved

s-mayani reviewed Jun 25, 2024

View reviewed changes

Remove some dead code, move everything particle related into fel

3906349

s-mayani requested a review from anekslen July 18, 2024 09:02

anekslen mentioned this pull request Oct 31, 2024

Merge branch from pullrequest #289 with master branch of ippl anekslen/ippl#3

Closed

Merge branch 'FDTDPullRequest' into migrate_from_working_experiments

b4ada1c

anekslen mentioned this pull request Jun 17, 2025

FDTD solver #362

Merged

Conversation

manuel5975p commented May 5, 2024

Open questions

Design

Uh oh!

manuel5975p commented May 24, 2024

Uh oh!

aaadelmann commented May 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s-mayani Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s-mayani Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srikrrish commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

s-mayani Jun 24, 2024 •

edited

Loading

s-mayani Jun 25, 2024 •

edited

Loading