Conversation
…o link tests with external files
…g BC (Absorbing BC are not implemented very nicely, this could be improved, base code from Manuel)
… pythonscript to recreate convergence plot
aaadelmann
requested changes
Jun 18, 2025
aaadelmann
approved these changes
Jun 19, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
Collaborator
There was a problem hiding this comment.
should we move all the FDTD tests to a new solver directory called electromagnetism or maxwell_solver or something like that? what do you think @aaadelmann?
Collaborator
There was a problem hiding this comment.
Having seen the readme below, I think it might make sense to just make a separate directory called fdtd_solver with the tests and put the readme there, as this readme does not concern any of the other tests in test/solver.
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
reviewed
Jun 20, 2025
s-mayani
requested changes
Jun 20, 2025
Collaborator
s-mayani
left a comment
s-mayani
left a comment
There was a problem hiding this comment.
Left some comments.
In general, I think the IPPL clang formatting needs to be applied.
Also, I am not sure about the error computation in the tests.
Collaborator
Author
|
After correcting the error calculation, these are the two new convergence plots:
|
s-mayani
reviewed
Jun 24, 2025
s-mayani
reviewed
Jun 24, 2025
s-mayani
reviewed
Jun 24, 2025
s-mayani
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Standard and Non-Standard Finite Difference Time Domain Solvers to IPPL.
This replaces the Solver part of pullrequest #289.
There are two testcases for both the solvers in test/solvers/. One of them is the convergence test. The results for both solvers can be seen in the images below: