Skip to content

Decrepidos patch 1 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LaurenceRLewis wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Decrepidos patch 1 #21

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a0e3a02
Testing only
LaurenceRLewis Oct 11, 2017
d6b83c9
Still testing
LaurenceRLewis Oct 11, 2017
b56392b
Still having fun testing things
LaurenceRLewis Oct 11, 2017
f323711
And on we go
LaurenceRLewis Oct 11, 2017
fa774e1
Targeting FontAwesome icons
LaurenceRLewis Oct 11, 2017
d974454
Getting the FA bit right
LaurenceRLewis Oct 11, 2017
a6ba63e
Still learning how to compile :not correctly
LaurenceRLewis Oct 11, 2017
2dec4cc
Latest change
LaurenceRLewis Oct 11, 2017
6e00e91
Trial and error
LaurenceRLewis Oct 11, 2017
ffcb519
Added and removed the following
LaurenceRLewis Oct 11, 2017
aeefe47
Added recognition for MathJax
LaurenceRLewis Oct 11, 2017
876c273
Removing MathJax from obsolete or non-standard
LaurenceRLewis Oct 11, 2017
ec78cb0
Test new changes
LaurenceRLewis Oct 11, 2017
61f96c7
Forgot to add ()
LaurenceRLewis Oct 11, 2017
9722884
Trying again
LaurenceRLewis Oct 11, 2017
0beeaf7
Add MAthJax to styling red box
LaurenceRLewis Oct 11, 2017
dbe0d8e
Added to BS section for sr-only screen reader test
LaurenceRLewis Oct 11, 2017
dc0972c
Removed sr-only and MathJax for pull request
LaurenceRLewis Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions revenge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,18 +231,27 @@ button.disabled:not([disabled]):not([readonly])::after {
acronym::after, applet::after, basefont::after, big::after, center::after, dir::after,
font::after, frame::after, frameset::after, isindex::after, listing::after, menu::after, multicol::after,
plaintext::after, strike::after, u::after, xmp::after, bgsound::after, blink::after, comment::after,
embed::after, marquee::after, nobr::after, noembed::after, wbr::after {
embed::after, marquee::after, nobr::after, noembed::after, wbr::after, :not(span.MathJax .math)::after {
content: 'This element is deprecated, non-standard or obsolete.' !important;
}

/**
* Empty elements
----------------------------------------------------------------------
*/

*:empty:not(script):not(input):not(br):not(img):not(link):not(hr):not(embed):not(area):not(command):not(col):not(param):not(source):not(track):not(wbr):not(base):not(keygen)::after {
/***
Added not:span.fa and i.fa to exclude icons hooks.
***/
*:empty:not(script):not(input):not(br):not(img):not(link):not(hr):not(embed):not(area):not(command):not(col):not(param):not(source):not(track):not(wbr):not(base):not(keygen):not(span.fa):not(i.fa)::after {
content: 'This element is empty. Why?' !important;
}
/**
Icons used for pure decoration or visual styling
----------------------------------------------------------------------
*/
i.fa:not([aria-hidden="true"])::after, span.fa:not([aria-hidden="true"])::after {
content: 'Use aria-hidden="true on icons.' !important;
}

/**
* Sectioning elements, headers and footers
Expand All @@ -261,14 +270,21 @@ aside > section:first-child::after {
content: 'Sectioning elems are not arbitrary wrappers. Use <div>s here.' !important;
}

body > header:not([role="banner"])::after, body > div > header:not([role="banner"])::after {
content: 'Use role="banner" on this header element.' !important;
}

body > footer:not([role="contentinfo"])::after, body > div > footer:not([role="contentinfo"])::after {
content: 'Use role="contentinfo" on this footer element.' !important;
/****
Removed as <footer> requires role=contentInfo and <header> requires role=banner as these are already conveyed natively. W3C validator generates a warning if used.
----------------------------------------------------------------------
*/

/***
if div has class or ID of header.
----------------------------------------------------------------------
*/
div#header:not([role="banner"])::after, div.header:not([role="banner"])::after {
content: 'Use role="banner" on this header element or use native <header>.' !important;
}


section [role="banner"]::after, section [role="contentinfo"]::after,
article [role="banner"]::after, article [role="contentinfo"]::after,
aside [role="banner"]::after, aside [role="contentinfo"]::after {
Expand Down Expand Up @@ -380,4 +396,4 @@ button.disabled:not([disabled])::after {

[data-toggle="dropdown"]:not([aria-haspopup])::after {
content: 'Indicate the hidden menu with aria-haspopup' !important;
}
}