Decrepidos patch 1 #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing changes before committing for comment
.fa:not([aria-hidden="true"])::after {
content: 'Use aria-hidden="true on icons.' !important;
}
:not(i.fa[aria-hidden="true"])::after, :not(span.fa[aria-hidden="true"])::after {
content: 'Use aria-hidden="true on icons.' !important;
}
Added not:span.fa and i.fa to exclude icons hooks on empty elements.
Added i.fa:not([aria-hidden="true"])::after, span.fa:not([aria-hidden="true"])::after {
content: 'Use aria-hidden="true on icons.' !important;
} to make sure aria-hidden is included on icons
/****
Removed as <footer> requires role=contentInfo and <header> requires role=banner as these are already conveyed natively. W3C validator generates a warning if used.
****/
/*
body > div#footer:not([role="contentinfo"])::after, body > div.footer:not([role="contentinfo"])::after {
content: 'Use role="contentinfo" on this footer element or use native HTML5 <footer>.' !important;
}
body > div#header:not([role="banner"])::after, body > div.header:not([role="banner"])::after, body > div.banner:not([role="banner"])::after, body > div#banner:not([role="banner"])::after {
content: 'Use role="banner" on this header element or use native <header>.' !important;
}
*/
/***
if div has class or ID of header but is not a native element include role. Considering if .banner #banner should be included
*/
div#header:not([role="banner"])::after, div.header:not([role="banner"])::after {
content: 'Use role="banner" on this header element or use native <header>.' !important;
}
These are just personal observations.
:not.MathJax::after {
content: 'This element is deprecated, non-standard or obsolete.' !important;
}
span.MathJax .math::after {
content: 'This is a MathJax symbol.' !important;
}
:not(.MathJax)::after {
content: 'This element is deprecated, non-standard or obsolete.' !important;
}
:not(span.MathJax .math)::after {
content: 'This element is deprecated, non-standard or obsolete.' !important;
}
.sr-only:after{
content: 'Off-screen text for screen reader users. Is this text necessary?' !important;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or removed the following:
Added:
not:span.fa and i.fa to exclude Font Awesomeicons hooks on empty elements.
Added:
i.fa:not([aria-hidden="true"])::after, span.fa:not([aria-hidden="true"])::after {
content: 'Use aria-hidden="true on icons.' !important;
} to make sure aria-hidden is included on icons
Added: if div has class or ID of header but is not a native element include role.
div#header:not([role="banner"])::after, div.header:not([role="banner"])::after {
content: 'Use role="banner" on this header element or use native
.' !important;
}
Removed Section:
requires role=contentInfo and requires role=banner as these are already conveyed natively. W3C validator generates a warning if used.