integrate happy session keys #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2025
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ultraviolet10
changed the title
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
2 times, most recently
from
eec16f5 to
b2d04f1
Compare
ultraviolet10
force-pushed
the
aritra/happy-primodium-client
branch
2 times, most recently
from
f480155 to
2cbc62d
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
b2d04f1 to
cf608ca
Compare
ultraviolet10
force-pushed
the
aritra/happy-primodium-client
branch
from
2cbc62d to
70afda9
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
cf608ca to
5efc8e1
Compare
aodhgan
reviewed
Apr 10, 2025
| toast.success(`Session account detected! (${sessionAccount.address.slice(0, 7)})`); | ||
| }, [sessionAccount]); | ||
| if (!isSessionRegistered(playerAddress)) return; | ||
| toast.success(`Session account detected! (${playerAddress.slice(0, 7)})`); |
There was a problem hiding this comment.
nit: keep the terminology consistent: account -> key
ultraviolet10
force-pushed
the
aritra/happy-primodium-client
branch
from
70afda9 to
511d8f9
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
87f014a to
ef64724
Compare
ultraviolet10
force-pushed
the
aritra/happy-primodium-client
branch
from
511d8f9 to
35a200b
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
ef64724 to
62b9e0f
Compare
ultraviolet10
changed the base branch from
aritra/happy-primodium-client
to
graphite-base/4
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
62b9e0f to
4102a6b
Compare
ultraviolet10
changed the base branch from
graphite-base/4
to
04-15-add_deployed_indexer_url
Merged
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
4102a6b to
0c7164e
Compare
ultraviolet10
force-pushed
the
04-15-add_deployed_indexer_url
branch
from
0157002 to
ee3f89c
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
0c7164e to
03ef470
Compare
ultraviolet10
force-pushed
the
aritra/integrate-session-keys
branch
from
03ef470 to
36fe8b7
Compare
Base automatically changed from
04-15-add_deployed_indexer_url
to
aritra/happy-primodium-client
April 22, 2025 16:31
ultraviolet10
changed the base branch from
aritra/happy-primodium-client
to
graphite-base/4
ultraviolet10
force-pushed
the
graphite-base/4
branch
from
285c8d9 to
5080867
Compare
ultraviolet10
changed the base branch from
graphite-base/4
to
04-15-add_deployed_indexer_url
ultraviolet10
changed the base branch from
04-15-add_deployed_indexer_url
to
aritra/happy-primodium-client
Author
|
changes tracked in #7 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Integrated Happy Wallet for session key management, replacing the custom session account implementation.
What changed?
requestSessionKeyfunctionalityHAPPY_STORAGE_PREFIXto track whether the player has registered session keys