forked from primodiumxyz/primodium
-
Notifications
You must be signed in to change notification settings - Fork 0
happychain 🤝🏻 primodium/core #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 4, 2025
b9a3c9c to
a2e22e8
Compare
aodhgan
reviewed
Apr 10, 2025
| }, | ||
| }; | ||
|
|
||
| export const happyChainSepolia: ChainConfig = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we might export this from @happy.tech/core ?
aodhgan
reviewed
Apr 10, 2025
| try { | ||
| const txHash = await txPromise; | ||
| await waitForTransaction(txHash); | ||
| // await waitForTransaction(txHash); // doesn't work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
aodhgan
approved these changes
Apr 10, 2025
9c094d5 to
32364c4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

TL;DR
Added support to the primodium/core package for HappyChain Sepolia network by integrating the
@happy.tech/corepackage.What changed?
@happy.tech/coredependency to the core packagehappyChainSepoliachain configuration with ID 216chainConfigsobjectcreateExternalAccountto accept a custom transport parameter that uses the happyProvider. UpdatedAccountClientProviderto use the HappyChain provider when connecting to external accounts.