Vendor Boost.Preprocessor #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks great! Let's just delete the cpp_bindgen stuff from here. I guess we should let cpp_bindgen rest in peace... |
Contributor
Author
Great, thanks for having a look. I'll attempt to remove all traces of cpp_bindgen in that case, unless you think it may be more complicated than it looks... |
msimberg
commented
Feb 26, 2025
msimberg
commented
Feb 26, 2025
Contributor
Author
|
cscs-ci run |
Contributor
Author
|
cscs-ci run |
Contributor
Author
|
I haven't touched the |
havogt
approved these changes
Feb 27, 2025
Contributor
havogt
left a comment
havogt
left a comment
There was a problem hiding this comment.
I propose to fix a typo to prove that I read your README. ;)
This is great. Thanks a lot.
Co-authored-by: Hannes Vogt <hannes@havogt.de>
Contributor
|
cscs-ci run |
havogt
pushed a commit
that referenced
this pull request
Apr 11, 2025
This vendors Boost.Preprocessor from Boost 1.87.0 (https://github.com/boostorg/preprocessor/tree/boost-1.87.0, same as 1.85.0). I used a little helper script in `tools/vendor_boost_preprocessor/vendor_boost_preprocessor.py` (let me know what the best location for that would be) to help. This vendors only the headers from Boost.Preprocessor that gridtools actually uses (including transitive includes of course). Macros are renamed to `GT_PP_*` (from `BOOST_PP_*`). The vendored headers are now in `include/gridtools/preprocessor`. I'm not sure if you want to have them in some slightly less conspicuous place? Do you consider any `GT_*` macros to be part of the public API, or is that unspecified (should they be called `GT_IMPL_PP_*` instead)? There are 226 vendored headers, compared to 400 in the upstream Boost version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors Boost.Preprocessor from Boost 1.87.0 (https://github.com/boostorg/preprocessor/tree/boost-1.87.0, same as 1.85.0).
This requires #1816 (and is based on top of it).
I used a little helper script in
tools/vendor_boost_preprocessor/vendor_boost_preprocessor.py(let me know what the best location for that would be) to help. This vendors only the headers from Boost.Preprocessor that gridtools actually uses (including transitive includes of course). Macros are renamed toGT_PP_*(fromBOOST_PP_*). The vendored headers are now ininclude/gridtools/preprocessor. I'm not sure if you want to have them in some slightly less conspicuous place? Do you consider anyGT_*macros to be part of the public API, or is that unspecified (should they be calledGT_IMPL_PP_*instead)?There are 226 vendored headers, compared to 400 in the upstream Boost version.