Vendor demangle.hpp header from Boost
#1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
havogt
approved these changes
Feb 19, 2025
Contributor
havogt
left a comment
havogt
left a comment
There was a problem hiding this comment.
Great! I am currently adding back a CSCS CI, then we can merge.
Contributor
Author
|
cscs-ci run |
1 similar comment
Contributor
Author
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the
demangle.hppheader from Boost (https://github.com/boostorg/core/blob/787b03ea9ca35089cecb80c5f2ca37e10046fbaf/include/boost/core/demangle.hpp) and moves it into thegridtoolsnamespace.I've done this conversion manually, since it's only one header and it hasn't changed in the last 9 years in Boost. The dependency on
boost/config.hppin the original version is only forBOOST_HAS_PRAGMA_ONCE(replaced to use#pragma onceunconditionally),BOOST_GCC(check for__GNUC__directly) andBOOST_NOEXCEPT(usenoexceptunconditionally).This is part one of two for removing boost as a dependency. The second part to remove Boost.Preprocessor is #1817.