Skip to content

Iterator view: changes in prototype implementation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Iterator view: changes in prototype implementation #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Iterator-View.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ is the same as

### Concepts

- **Axis** - a tag denoting a dimension of the domain
- **NamedRange** - can be passed to `domain` builtin
- **Domain** - can be followed by the `:domain` designator in the fencil definition.
- **Value** - a type that potentially can be stored in the field.
- **Location** - one of `:cell`, `:vertex` or `:edge`
Expand All @@ -243,8 +245,8 @@ is the same as
### Signatures

```cpp=
Domain cartesian(int i0, int i1, int j0, int j1, int k0, int k1);
Domain unstructured(Location, int hor0, int hor1, int k0, int k1);
NamedRange named_range(Axis, int begin, int end)
Domain domain(NamedRange...);
Copy link
Contributor

@havogt havogt Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to distinguish Cartesian and unstructured by its domain as anyway we need more information at compile/generation time about the concrete offset interpretation. E.g. max neighbors for a neighbor table.


// Iterators API
Stencil<Iterator<V>, V> shift(Offsets...);
Expand Down Expand Up @@ -272,8 +274,8 @@ is the same as
To cast<To>(From);

// ternary operator
V if(bool, V, V);
Column<V> if(Column<bool>, Column<V>, Column<V>);
V if_(bool, V, V);
Column<V> if_(Column<bool>, Column<V>, Column<V>);

// conditionals
bool eq(V, V);
Expand Down Expand Up @@ -302,9 +304,9 @@ is the same as
V minus(V, V);
Column<V> minus(Column<V>, Column<V>);

V mult(V, V);
Column<V> mult(Column<V>, Column<V>);
V mul(V, V);
Column<V> mul(Column<V>, Column<V>);

V divides(V, V);
Column<V> divides(Column<V>, Column<V>);
V div(V, V);
Column<V> div(Column<V>, Column<V>);
```