Iterator view: changes in prototype implementation #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Aug 5, 2021
| Domain cartesian(int i0, int i1, int j0, int j1, int k0, int k1); | ||
| Domain unstructured(Location, int hor0, int hor1, int k0, int k1); | ||
| NamedRange named_range(Axis, int begin, int end) | ||
| Domain domain(NamedRange...); |
Contributor
There was a problem hiding this comment.
There is no need to distinguish Cartesian and unstructured by its domain as anyway we need more information at compile/generation time about the concrete offset interpretation. E.g. max neighbors for a neighbor table.
havogt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened from wiki edit