Skip to content

Fix admittance task#7

Merged
tumaanna merged 7 commits into4.0-develfrom
fix-admittance-task
Apr 16, 2025
Merged

Fix admittance task#7
tumaanna merged 7 commits into4.0-develfrom
fix-admittance-task

Conversation

@tumaanna
Copy link

@tumaanna tumaanna commented Apr 15, 2025

  • Fix bug in computation of impedance params, where filter dt was not updated and resulted in wrong discretization of filter coefficients.
  • add setters, getters and bindings for task lambda, filter time step and filter omega
  • add method to setFilterTimeStep and expose it via python bindings to be able to reproduce this bug from python wrappers and achieve the original behavior

Copy link

@chpohl chpohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some minor things

@tumaanna tumaanna merged commit 449be6a into 4.0-devel Apr 16, 2025
1 check passed
@tumaanna tumaanna deleted the fix-admittance-task branch April 16, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants