Fix PR review feedback: port validation, test clarity, and remove version number heuristic

[Copilot]

Addresses four issues from PR #119 review feedback on IPv4/IPv6 detection implementation.

Port validation hardening

• PORT_SUFFIX_REGEX now enforces valid port range (0-65535) instead of accepting any 1-5 digit number
• Previous regex would match invalid ports like 99999 or 70000

Test comment accuracy

• Corrected misleading comment in test_ipv4_version_numbers
• Updated test expectations to reflect that all valid IPv4 addresses are now accepted

Version number heuristic removal

• Removed the version number filtering logic that rejected IPv4 addresses where all octets < 20
• is_ipv4_address() now accepts ALL valid IPv4 addresses in dotted-quad notation, even if they could be version numbers (e.g., "1.2.3.4")
• Removed the whitelist of common IPs (8.8.8.8, 1.1.1.1, etc.) that were exceptions to the heuristic
• Updated documentation to clarify that disambiguation between IP addresses and version numbers is the caller's responsibility
• This simplifies the code by ~30 lines and provides more predictable behavior

Minor fixes

• Fixed typo: "Simplicy" → "Simplicity" in code review hook name

The approach now favors accepting false positives (treating version numbers as IPs) over false negatives (rejecting legitimate IPs), allowing users to disambiguate based on context when necessary.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[unclesp1d3r]

@copilot Let's flip this around and allow false positives of version numbers. So any valid IPv4 or IPv6 should be returned as an IP, even if it actually could be a version number instead. It is better to let the user sort out of its a version number in those limited cases where it is in dotted-quad notation and each number is between 0 and 255.

[Copilot]

@copilot Let's flip this around and allow false positives of version numbers. So any valid IPv4 or IPv6 should be returned as an IP, even if it actually could be a version number instead. It is better...

Flipped the approach as requested. The version number heuristic has been removed, and all valid IPv4 addresses are now accepted, even if they could be version numbers like "1.2.3.4".

Changes:

• Removed the octet < 20 filter and common IP whitelist (~30 lines)
• Simplified is_ipv4_address() to only validate via std::net::Ipv4Addr
• Updated documentation to clarify caller responsibility for disambiguation
• Updated tests to expect version-like addresses to be accepted

All CI checks pass. Commit 2e7c1ec.