Add code review automation and Rust standards documentation with IPv4/IPv6 detection

[unclesp1d3r]

This pull request introduces new standards and automation for code simplicity, error handling, and configuration management for the Stringy project, primarily through documentation and automation files. The changes establish clear guidelines for code review, Rust project configuration, error handling patterns, and configuration management, aiming to ensure a maintainable, idiomatic, and reliable codebase.

Code Review and Automation:

• Added a code simplicity review prompt (.github/prompt/simplicity-review.prompt.md) and a corresponding command (.cursor/commands/simplicity_review.md) to guide manual and automated reviews for reducing complexity and test bloat. [1] [2]
• Introduced a Kiro automation hook (.kiro/hooks/code-review-refactor.kiro.hook) to automatically trigger a code simplicity review at the end of each agent run, enforcing the new review process.

Rust Project Standards and Guidance:

• Documented Rust project standards in .kiro/steering/rust/cargo-toml.md, specifying package structure, dependency choices, linting, and build profiles for Stringy.
• Added configuration management guidelines in .kiro/steering/rust/configuration-management.md, mandating CLI-only configuration (via clap), no config files or environment variables, and showing idiomatic argument validation.

Error Handling Standards:

• Established detailed error handling standards and patterns for Rust in .kiro/steering/rust/error-handling.md and .kiro/steering/rust/error-handling-patterns.md, including the use of thiserror, structured error types, propagation practices, error context, recovery strategies, and thorough error testing/documentation. [1] [2]

[coderabbitai]

Caution

Review failed

Failed to post review comments

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Summary by CodeRabbit

• New Features

  • IPv4 and IPv6 detection added to semantic classification with stricter validation
  • UTF‑16 little‑endian string extraction path added (refactored extraction to handle byte orders)

• Documentation

  • Added extensive Rust standards: configuration, linting, error handling, performance, and steering guides
  • Enhanced classification docs with detailed IP handling and examples
  • Added code‑simplicity review guidelines and an automated code‑review hook configuration

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Adds IPv4/IPv6 detection to the semantic classifier, consolidates UTF‑16 extraction into a generic byte‑order scanner, introduces multiple Rust steering documents and a code‑review/refactor hook, and updates documentation to reflect implemented IP detection and stricter IP validation.

Changes

Cohort / File(s)	Summary
Code Review Automation /.cursor/commands/simplicity_review.md, .github/prompt/simplicity-review.prompt.md, .kiro/hooks/code-review-refactor.kiro.hook	New AI-driven code‑simplicity review files and a .kiro hook that triggers an agent refactor prompt on agent stop.
Rust Steering & Standards .kiro/steering/rust/rust-standards.md, .kiro/steering/rust/cargo-toml.md, .kiro/steering/rust/configuration-management.md, .kiro/steering/rust/error-handling.md, .kiro/steering/rust/error-handling-patterns.md, .kiro/steering/rust/linting-rules.md, .kiro/steering/rust/performance-optimization.md	Seven new docs defining Rust project standards: cargo layout, lints, error handling patterns, configuration approach, performance guidance, and Clippy rules.
Docs: Classification & README README.md, docs/src/classification.md, src/classification/mod.rs	README clarified IP detection status; classification docs hardened IPv4/IPv6 patterns and added port/bracket handling and two‑stage validation; added crate/module doc comment.
IP Detection Implementation src/classification/semantic.rs	Added IPV4/IPv6/port/bracket regexes, port/brace stripping helpers, two‑stage validation, integrated IP tagging into classifier, and public methods is_ipv4_address, is_ipv6_address, classify_ip_addresses.
UTF‑16 Extraction Refactor src/extraction/utf16.rs	Introduced generic extract_utf16_strings_with_byte_order() handling LE/BE via ByteOrder, public extract_utf16le_strings(); merged LE/BE paths and deduplicated combined results with confidence rules.

Sequence Diagram(s)

(omitted — changes are feature additions and refactors that do not introduce a new multi‑component sequential runtime flow suitable for a sequence diagram)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related issues

• Implement IPv4 and IPv6 Address Pattern Detection in Semantic Classifier #16 — Implements IPv4/IPv6 detection and adds is_ipv4_address, is_ipv6_address, classify_ip_addresses in src/classification/semantic.rs, matching this PR's IP classification work.

Possibly related PRs

• feat(classification): add semantic classifier for URL and domain detection #118 — Modifies the same classification module to add URL/domain detection; closely related by extending semantic classification capabilities.

Poem

🐰 I nibble bytes and hop through nets,

Octets, brackets, and bracketed sets,
I tidy UTF‑16 with a clever stride,
Mark IPs where they like to hide,
Standards set, the code feels spry—hip hop, hop, hi!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately captures the main changes: code review automation, Rust standards documentation, and IPv4/IPv6 detection implementation.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, covering code review automation, Rust standards, error handling, and IP detection features.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 16-implement-ipv4-and-ipv6-address-pattern-detection-in-semantic-classifier

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request implements IPv4 and IPv6 address pattern detection in the semantic classifier, despite the title and description suggesting broader documentation and automation changes. The core functionality adds comprehensive IP address detection with support for ports, bracketed IPv6 notation, and heuristic-based false positive mitigation for version numbers.

Key Changes

• IPv4 and IPv6 address detection with two-stage validation (regex pre-filter + standard library parsing)
• Port suffix handling and IPv6 bracket notation support
• UTF-16 extraction code consolidation (LE/BE functions merged into a generic function)
• Comprehensive test coverage for IP address detection edge cases

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/classification/semantic.rs	Implements IPv4/IPv6 detection methods with validation, regex patterns, and 16 new test cases
src/extraction/utf16.rs	Refactors UTF-16LE and UTF-16BE extraction into a unified generic function
src/classification/mod.rs	Adds module-level documentation with usage examples
docs/src/classification.md	Updates IP address pattern documentation with implementation details
README.md	Updates feature list to reflect implemented IPv4/IPv6 detection
.kiro/steering/rust/*.md	Adds Rust coding standards, error handling patterns, configuration management, performance optimization, and linting rules documentation
.kiro/hooks/code-review-refactor.kiro.hook	Adds automation hook for code simplicity review
.github/prompt/simplicity-review.prompt.md	Adds code simplification review prompt template
.cursor/commands/simplicity_review.md	Adds simplicity review command reference

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[unclesp1d3r]

@copilot open a new pull request to apply changes based on the comments in this thread

In the case of the version number/ip octet heuristic, I think we should just accept the risk of a false positive in the case of a dotted quad notation that could be either a version number or an IP address. We should just document that this can happen sometimes.

Before commiting your code, run just ci-check and ensure all checks and tests are green.

[Copilot]

@unclesp1d3r I've opened a new pull request, #120, to work on those changes. Once the pull request is ready, I'll request review from you.