[GEN-1859] Json Log Formatter to not be lowercase and add AuditService tests #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive audit logging to login and logout operations to track user authentication activities. Implements logging for successful logins, failed login attempts, account lockouts, and logout events with user details and IP addresses for security monitoring. stack-info: PR: #473, branch: Jossec101/stack/16
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
Jossec101
added a commit
that referenced
this pull request
Jan 22, 2026
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
Jossec101
force-pushed
the
Jossec101/stack/17
branch
from
24a5269 to
f18e5d5
Compare
This was referenced Jan 22, 2026
Jossec101
force-pushed
the
Jossec101/stack/16
branch
from
93135a9 to
1fa3c9c
Compare
Jossec101
added a commit
that referenced
this pull request
Jan 22, 2026
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
Jossec101
force-pushed
the
Jossec101/stack/17
branch
from
f18e5d5 to
555ef90
Compare
Jossec101
force-pushed
the
Jossec101/stack/16
branch
from
1fa3c9c to
269ff6f
Compare
Jossec101
added a commit
that referenced
this pull request
Jan 22, 2026
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
Jossec101
force-pushed
the
Jossec101/stack/17
branch
from
555ef90 to
b47b203
Compare
Jossec101
added a commit
that referenced
this pull request
Jan 22, 2026
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
Jossec101
force-pushed
the
Jossec101/stack/17
branch
from
b47b203 to
c50b174
Compare
Jossec101
force-pushed
the
Jossec101/stack/16
branch
from
26e8427 to
ebbe102
Compare
Jossec101
force-pushed
the
Jossec101/stack/17
branch
from
c50b174 to
c020fa7
Compare
Jossec101
added a commit
that referenced
this pull request
Jan 22, 2026
…e tests Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now. Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases. stack-info: PR: #474, branch: Jossec101/stack/17
RodriFS
approved these changes
Jan 22, 2026
Comment on lines
+54
to
+56
| var trigger = TriggerBuilder.Create() | ||
| .WithIdentity($"{typeof(T).Name}Trigger-{identitySuffix}") | ||
| .StartNow() |
Contributor
There was a problem hiding this comment.
why the removal of the try/catch?
Contributor
There was a problem hiding this comment.
will this break something in datadog dashboards/monitoring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[GEN-1859] Json Log Formatter to not be lowercase and add AuditService tests
Mark LowerCaseJsonFormatter as obsolete to a new Json Formatter with caps. Logs were altered when caps are in, this is a legacy decision we are reverting now.
Add comprehensive unit tests for AuditService covering various scenarios including successful/failed repository operations, different HTTP contexts, and edge cases.