Skip to content

[GEN-1859] Audit logging to API tokens, nodes and channel operations #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jossec101 wants to merge 1 commit into
base: main
Choose a base branch
from
+218 −12
Open

[GEN-1859] Audit logging to API tokens, nodes and channel operations #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Data/Repositories/ChannelOperationRequestRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public async Task<List<ChannelOperationRequest>> GetAll()
.Include(request => request.SourceNode)
.Include(request => request.DestNode)
.Include(request => request.ChannelOperationRequestPsbts)
.Include(request => request.User)
.Include(x => x.Utxos)
.AsSplitQuery()
.ToListAsync();
Expand All @@ -84,6 +85,7 @@ public async Task<List<ChannelOperationRequest>> GetUnsignedPendingRequestsByUse
.Include(x => x.Wallet).ThenInclude(x => x.Keys)
.Include(request => request.DestNode)
.Include(request => request.ChannelOperationRequestPsbts)
.Include(request => request.User)
.Include(x => x.Utxos)
.Where(request => request.Wallet != null
&& request.Wallet.Keys.Count(key => userId == key.UserId) > request.ChannelOperationRequestPsbts.Count(req => req.UserSignerId == userId)
Expand Down
26 changes: 25 additions & 1 deletion src/Pages/Apis.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
@inject IAPITokenRepository APITokenRepository
@inject IToastService ToastService
@inject ILocalStorageService LocalStorageService
@inject IAuditService AuditService
@attribute [Authorize(Roles = "Superadmin")]
@code {

Expand Down Expand Up @@ -166,12 +167,24 @@
if (addResult.Item1)
{
await ShowCopyModalToken(arg.Item);
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Success,
AuditObjectType.APIToken,
arg.Item.Id.ToString(),
new { Name = arg.Item.Name });
}

else
{
ToastService.ShowError("Something went wrong");
_apiTokens.Remove(arg.Item);
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Failure,
AuditObjectType.APIToken,
null,
new { Name = arg.Item.Name, Error = addResult.Item2 });
}
}

Expand Down Expand Up @@ -215,11 +228,22 @@
if (result)
{
ToastService.ShowSuccess(blockIt ? "Token blocked" : "Token unblocked");
await AuditService.LogAsync(
blockIt ? AuditActionType.Block : AuditActionType.Unblock,
AuditEventType.Success,
AuditObjectType.APIToken,
contextItem.Id.ToString(),
new { Name = contextItem.Name });
}
else
{
ToastService.ShowError("Something went wrong");

await AuditService.LogAsync(
blockIt ? AuditActionType.Block : AuditActionType.Unblock,
AuditEventType.Failure,
AuditObjectType.APIToken,
contextItem.Id.ToString(),
new { Name = contextItem.Name });
}

await GetData();
Expand Down
106 changes: 106 additions & 0 deletions src/Pages/ChannelRequests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@
}
</DisplayTemplate>
</DataGridColumn>
<DataGridColumn TItem="ChannelOperationRequest" Field="User.UserName" Caption="Requestor" Sortable="false" Displayable="@IsPendingRequestsColumnVisible(PendingChannelsColumnName.Requestor)">
<DisplayTemplate>
@(context?.User?.UserName ?? "N/A")
</DisplayTemplate>
</DataGridColumn>
<DataGridColumn TItem="ChannelOperationRequest" Field="@nameof(ChannelOperationRequest.Status).Humanize(LetterCasing.Sentence)" Caption="Status" Sortable="false" Displayable="@IsPendingRequestsColumnVisible(PendingChannelsColumnName.Status)">
<DisplayTemplate>
@context?.Status.Humanize()
Expand Down Expand Up @@ -338,6 +343,11 @@
}
</DisplayTemplate>
</DataGridColumn>
<DataGridColumn TItem="ChannelOperationRequest" Field="User.UserName" Caption="Requestor" Sortable="false" Displayable="@IsAllRequestsColumnVisible(AllChannelsColumnName.Requestor)">
<DisplayTemplate>
@(context?.User?.UserName ?? "N/A")
</DisplayTemplate>
</DataGridColumn>
<DataGridColumn TItem="ChannelOperationRequest" Field="@nameof(ChannelOperationRequest.Status)" Caption="Status" Sortable="false" Displayable="@IsAllRequestsColumnVisible(AllChannelsColumnName.Status)">
<DisplayTemplate>
<Row Style="white-space: nowrap;">
Expand Down Expand Up @@ -404,7 +414,7 @@
TemplatePsbtString="@_templatePSBTString"
SignedPSBT="@_psbt"/>

<CancelOrRejectPopup

Check warning on line 417 in src/Pages/ChannelRequests.razor

View workflow job for this annotation

GitHub Actions / build-and-test 

Component 'CancelOrRejectPopup' expects a value for the parameter 'Reason', but a value may not have been provided.
@ref=@_rejectCancelModalRef
Title='@(_selectedStatusActionString + " operation: " + _selectedRequest?.Id)'
Validator="@RejectReasonValidator"
Expand Down Expand Up @@ -443,6 +453,8 @@
@inject INBXplorerService NBXplorerService
@inject ILocalStorageService LocalStorageService
@inject IPriceConversionService PriceConversionService
@inject IAuditService AuditService
@inject IHttpContextAccessor HttpContextAccessor

@code {
private List<ChannelOperationRequest>? _channelRequests;
Expand Down Expand Up @@ -514,6 +526,7 @@
public static readonly ColumnDefault Private = new("Private");
public static readonly ColumnDefault SignaturesCollected = new("Signatures Collected");
public static readonly ColumnDefault Status = new("Status");
public static readonly ColumnDefault Requestor = new("Requestor");
}

public abstract class AllChannelsColumnName
Expand All @@ -526,6 +539,7 @@
public static readonly ColumnDefault Private = new("Private");
public static readonly ColumnDefault SignaturesCollected = new("Signatures Collected");
public static readonly ColumnDefault Status = new("Status");
public static readonly ColumnDefault Requestor = new("Requestor");
public static readonly ColumnDefault CreationDate = new("Creation Date");
public static readonly ColumnDefault UpdateDate = new("Update Date");
public static readonly ColumnDefault Links = new("Links");
Expand Down Expand Up @@ -705,6 +719,15 @@
if (createChannelResult.Item1)
{
ToastService.ShowSuccess("Open channel request created!");
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Success,
AuditObjectType.ChannelOperationRequest,
request.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { Amount = amount, SourceNodeId = _selectedSourceNodeId, DestNodeId = _selectedDestNode?.Id, Description = $"Channel open request created. Amount: {amount} BTC, SourceNodeId: {_selectedSourceNodeId}, DestNodeId: {_selectedDestNode?.Id}" });

if (_selectedUTXOs.Count > 0)
{
Expand All @@ -714,6 +737,15 @@
else
{
ToastService.ShowError(createChannelResult.Item2);
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Failure,
AuditObjectType.ChannelOperationRequest,
null,
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { Error = createChannelResult.Item2, Description = $"Failed to create channel open request. Error: {createChannelResult.Item2}" });
}
_utxoSelectorModalRef.ClearModal();
}
Expand Down Expand Up @@ -765,10 +797,30 @@
if (!jobUpdateResult.Item1)
{
ToastService.ShowError("There has been an error when updating the request");
var failActionType = _selectedStatus == ChannelOperationRequestStatus.Rejected ? AuditActionType.Reject : AuditActionType.Cancel;
await AuditService.LogAsync(
failActionType,
AuditEventType.Failure,
AuditObjectType.ChannelOperationRequest,
_selectedRequest.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = _selectedRequest.Id, Status = _selectedStatus, Description = $"Failed to {_selectedStatus.ToString().ToLower()} channel operation request" });
}
else
{
ToastService.ShowSuccess("Request " + _selectedStatus);
var successActionType = _selectedStatus == ChannelOperationRequestStatus.Rejected ? AuditActionType.Reject : AuditActionType.Cancel;
await AuditService.LogAsync(
successActionType,
AuditEventType.Success,
AuditObjectType.ChannelOperationRequest,
_selectedRequest.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = _selectedRequest.Id, Status = _selectedStatus, Reason = _selectedRequest.ClosingReason, Description = $"Channel operation request {_selectedStatus.ToString().ToLower()}" });
await FetchRequests();
}
}
Expand Down Expand Up @@ -835,6 +887,15 @@
if (addResult.Item1)
{
ToastService.ShowSuccess("Signature collected");
await AuditService.LogAsync(
AuditActionType.Sign,
AuditEventType.Success,
AuditObjectType.ChannelOperationRequest,
_selectedRequest.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = _selectedRequest.Id, Description = "PSBT signature collected for channel operation request" });

_selectedRequest = await ChannelOperationRequestRepository.GetById(_selectedRequest.Id);

Expand All @@ -847,6 +908,15 @@
else
{
ToastService.ShowError("Error while saving the signature");
await AuditService.LogAsync(
AuditActionType.Sign,
AuditEventType.Failure,
AuditObjectType.ChannelOperationRequest,
_selectedRequest.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = _selectedRequest.Id, Description = "Failed to save PSBT signature for channel operation request" });
}

await FetchRequests();
Expand Down Expand Up @@ -880,10 +950,28 @@
if (createChannelResult.Item1)
{
ToastService.ShowSuccess("Open channel request created!");
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Success,
AuditObjectType.ChannelOperationRequest,
_selectedRequest.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { Amount = new Money(_selectedRequest.SatsAmount).ToUnit(MoneyUnit.BTC), SourceNodeId = _selectedRequest.SourceNodeId, DestNodeId = _selectedRequest.DestNodeId, IsHotWallet = true, Description = "Hot wallet channel open request created" });
}
else
{
ToastService.ShowError(createChannelResult.Item2);
await AuditService.LogAsync(
AuditActionType.Create,
AuditEventType.Failure,
AuditObjectType.ChannelOperationRequest,
null,
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { Error = createChannelResult.Item2, IsHotWallet = true, Description = "Failed to create hot wallet channel open request" });
_utxoSelectorModalRef.ClearModal();
await _approveOperationConfirmationModal.CloseModal();
return;
Expand Down Expand Up @@ -977,10 +1065,28 @@
var scheduler = await SchedulerFactory.GetScheduler();
await scheduler.DeleteJob(new JobKey($"{nameof(ChannelOpenJob)}-{request.Id}"));
if (!ChannelOperationRequestRepository.Update(request).Item1) throw new Exception();
await AuditService.LogAsync(
AuditActionType.Update,
AuditEventType.Success,
AuditObjectType.ChannelOperationRequest,
request.Id.ToString(),
LoggedUser.Id,
LoggedUser.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = request.Id, NewStatus = ChannelOperationRequestStatus.Failed, Description = "Channel operation request marked as failed" });
}
catch (Exception? e)
{
ToastService.ShowError("Error while marking request as failed");
await AuditService.LogAsync(
AuditActionType.Update,
AuditEventType.Failure,
AuditObjectType.ChannelOperationRequest,
_selectedRequestForMarkingAsFailed?.Id.ToString(),
LoggedUser?.Id,
LoggedUser?.UserName,
HttpContextAccessor.HttpContext?.GetClientIpAddress(),
new { RequestId = _selectedRequestForMarkingAsFailed?.Id, Description = "Failed to mark channel operation request as failed" });
}
finally
{
Expand Down
Loading
Loading