-
Notifications
You must be signed in to change notification settings - Fork 10
Use TFInfo to unify TF specifications #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Contributor
Author
|
Hi, I have just tested this refactor in:
So everything looks good to me :) |
…depending on filter mode: local or global. This first version works as only global filter, so I changed world frame to map
Contributor
|
I created a new PR to fix frames in fusion_localizer PR 41 |
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Contributor
Author
|
Fixed frames. In robot_localization, world frame must be odom or map …
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
…lugins into set_robot_frame
Contributor
Author
|
Ready to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is an adaptation to EasyNavigation/EasyNavigation#80 . Of course, test will not pass until it is merged, but I want to present the changes as a draft
Do not merge until I carefully test most use cases
I suspect that the refactor of
easynav_fusion_localizeris not correct at all, as there is abase_link_output_frame_id_that I do not understand very well. Please, @midemig , review the changes related to this plugin, and fix anything you see wrong.