Skip to content

Conversation

@fmrico
Copy link
Contributor

@fmrico fmrico commented Dec 5, 2025

Hi,

This PR is an adaptation to EasyNavigation/EasyNavigation#80 . Of course, test will not pass until it is merged, but I want to present the changes as a draft

Do not merge until I carefully test most use cases

I suspect that the refactor of easynav_fusion_localizer is not correct at all, as there is a base_link_output_frame_id_ that I do not understand very well. Please, @midemig , review the changes related to this plugin, and fix anything you see wrong.

Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
@fmrico
Copy link
Contributor Author

fmrico commented Dec 6, 2025

Hi,

I have just tested this refactor in:

Param file Robot Sim/Real World Sensors Maps Managers Localizer Planner Controller Checked
Test1 Kobuki None None None Dummy Dummy Dummy Dummy
Test2 Kobuki Sim House Laser Simple AMCL/Simple Dummy Dummy
Test3 Kobuki Sim House Laser Simple AMCL/Simple A*/Simple Simple
Test4 Kobuki Sim House Laser Costmap (obstacles + inflation) AMCL/Costmap A*/Costmap Serest
Test5 Kobuki Sim House Laser Costmap (obstacles + inflation) + Routes AMCL/Costmap A*/Costmap MPPI
Test6 Kobuki Sim House Laser Costmap (obstacles + inflation) AMCL/Costmap A*/Costmap MPC + Collision
Test7 Summit XL Sim URJC Dig Laser 3D NavMap LidarSlam A*/NavMap MPC
Test8 Summit XL Sim URJC Dig Laser 3D Bonxai + NavMap (obstacles + inflation) AMCL A*/NavMap MPC

So everything looks good to me :)

…depending on filter mode: local or global. This first version works as only global filter, so I changed world frame to map
@midemig
Copy link
Contributor

midemig commented Dec 10, 2025

I created a new PR to fix frames in fusion_localizer PR 41

Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
@fmrico
Copy link
Contributor Author

fmrico commented Dec 11, 2025

Param file Robot Sim/Real World Sensors Maps Managers Localizer Planner Controller Checked
Test1 Kobuki None None None Dummy Dummy Dummy Dummy
Test2 Kobuki Sim House Laser Simple AMCL/Simple Dummy Dummy
Test3 Kobuki Sim House Laser Simple AMCL/Simple A*/Simple Simple
Test4 Kobuki Sim House Laser Costmap (obstacles + inflation) AMCL/Costmap A*/Costmap Serest
Test5 Kobuki Sim House Laser Costmap (obstacles + inflation) + Routes AMCL/Costmap A*/Costmap MPPI
Test6 Kobuki Sim House Laser Costmap (obstacles + inflation) AMCL/Costmap A*/Costmap MPC + Collision
Test7 Summit XL Sim URJC Dig Laser 3D NavMap LidarSlam A*/NavMap MPC
Test8 Summit XL Sim URJC Dig Laser 3D Bonxai + NavMap (obstacles + inflation) AMCL A*/NavMap MPC

@fmrico
Copy link
Contributor Author

fmrico commented Dec 11, 2025

Ready to review

Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
@fmrico fmrico merged commit b242113 into EasyNavigation:rolling Dec 15, 2025
1 check passed
@fmrico fmrico deleted the set_robot_frame branch December 15, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants