Skip to content

feat: implement Redfish v1.11.0 compliant ComputerSystem reset actions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nmgaston wants to merge 9 commits into from
Closed

feat: implement Redfish v1.11.0 compliant ComputerSystem reset actions #13

nmgaston wants to merge 9 commits into from

Conversation

@nmgaston
Copy link
Collaborator

@nmgaston nmgaston commented Oct 17, 2025 •
edited
Loading

Summary

Implements comprehensive Redfish v1.11.0 compliant ComputerSystem reset functionality with proper error handling, validation, and asynchronous task responses.

  • Add comprehensive reset type validation (GracefulShutdown, GracefulRestart, ForceOff, ForceOn, ForceRestart, Nmi, PowerCycle)
  • Implement task-based asynchronous response pattern with secure task ID generation
  • Add power state conflict detection to prevent invalid operations
  • Enhance error handling with Redfish-compliant message registry responses
  • Add comprehensive input validation and sanitization
  • Implement proper HTTP status codes per Redfish standard

@nmgaston nmgaston force-pushed the redfish-computersystem-reset branch 3 times, most recently from faa08a4 to f6f84bc Compare October 18, 2025 00:40
@nmgaston nmgaston marked this pull request as ready for review October 18, 2025 00:47
@nmgaston nmgaston mentioned this pull request Oct 18, 2025
Closed
sudhir-intc
sudhir-intc reviewed Oct 22, 2025
View reviewed changes
@nmgaston nmgaston requested a review from sudhir-intc October 22, 2025 20:50
@nmgaston nmgaston force-pushed the redfish-computersystem-reset branch from 7b1f813 to f58c5df Compare October 22, 2025 21:46
@nmgaston nmgaston marked this pull request as draft October 23, 2025 15:18
@nmgaston nmgaston force-pushed the redfish-computersystem-reset branch 2 times, most recently from f9902a7 to d45f2b0 Compare October 23, 2025 17:00
@nmgaston nmgaston marked this pull request as ready for review October 23, 2025 23:49
rsdmike
rsdmike reviewed Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things to leverage that exist already, otherwise looks good to me.

@nmgaston nmgaston requested a review from rsdmike October 25, 2025 18:41
@nmgaston
Copy link
Collaborator Author

nmgaston commented Oct 30, 2025

Moved to a different fork. Not to be used.

@nmgaston nmgaston closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DevipriyaS17 DevipriyaS17 Awaiting requested review from DevipriyaS17

@sudhir-intc sudhir-intc Awaiting requested review from sudhir-intc

@madhavilosetty-intel madhavilosetty-intel Awaiting requested review from madhavilosetty-intel

@rsdmike rsdmike Awaiting requested review from rsdmike

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmgaston @rsdmike @sudhir-intc