Redish Compliance for ComputerSystem.Reset endpoint #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmgaston
changed the title
- Add Redfish v1.11.0 Base Registry compliant error responses - Implement ComputerSystem.Reset endpoint with proper HTTP status codes - Add power state conflict detection (409 responses for redundant operations) - Create reusable error handling functions for Base Registry messages - Implement proper API versioning structure (/redfish/v1/) - Add comprehensive Redfish documentation and examples - Remove build artifacts and update .gitignore This implementation provides a fully compliant Redfish API v1 endpoint that follows DMTF specifications and industry best practices.
- Implement 405 Method Not Allowed with proper Allow headers - Add Redfish-compliant authentication error responses (401/403) - Create RedfishJWTAuthMiddleware for proper Base Registry error handling - Update resolution text to match Redfish Base Registry v1.11.0 specification - Add NoValidSessionError and InsufficientPrivilegeError functions - Apply Redfish authentication to both Systems and Service Root endpoints All error responses now follow DMTF Redfish Base Message Registry v1.11.0
- Add ServiceUnavailableError (502) for upstream device communication failures - Add ServiceTemporarilyUnavailableError (503) for service overload/maintenance - Implement isUpstreamCommunicationError() detection for network/AMT/WSMAN errors - Implement isServiceTemporarilyUnavailable() detection for overload conditions - Add comprehensive error handling hierarchy: 404 -> 503 -> 502 -> 500 - Include Retry-After header for 503 responses - Add extensive test coverage for all error scenarios - Maintain 100% test coverage with 193+ test cases - Full Redfish DMTF Base Registry v1.11.0 compliance
…with full error handling - Add DMTF-compliant ServiceRoot endpoint with proper UUID generation - Implement comprehensive HTTP error handling (401, 405, 406, 500, 502, 503) - Add Redfish Base Registry v1.11.0 compliant error responses - Implement service health monitoring with extensible health check functions - Add proper Accept header validation and 406 Not Acceptable responses - Implement HTTP method restrictions with proper 405 Method Not Allowed responses - Add RedfishRecoveryMiddleware for panic recovery with 500 error responses - Extend SessionService and Sessions collection endpoints with proper error handling - Add comprehensive test suite (486 lines) covering all endpoints and error conditions - Include UUID v4 generation with cryptographic randomness and fallback - Add extensible health check framework for future 502/503 error detection - Implement proper OData headers and DMTF specification compliance - Add detailed error messages with resolution guidance per Base Registry This implementation provides a production-ready, fully DMTF-compliant Redfish service root that handles all error conditions gracefully and provides comprehensive logging and monitoring capabilities for enterprise deployment.
Collaborator
Author
|
Moved changes to PR #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Complete Redfish ComputerSystem.Reset with Full Error Handling
Overview
This PR implements a production-ready, fully Redfish DMTF-compliant ComputerSystem.Reset endpoint with comprehensive error handling, authentication, and extensive test coverage.
Key Features
Redfish DMTF Compliance
Comprehensive Error Handling
AllowheadersRetry-AfterheaderIntelligent Error Detection