Add deserialization tests for BytesThrottleConfig and LoadProfile #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TheSafo
changed the title
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
af8d207 to
cf2d888
Compare
Draft
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
cf2d888 to
e564637
Compare
TheSafo
force-pushed
the
jsaf/throttle-error-change
branch
from
891a604 to
242e45f
Compare
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
e564637 to
a1be97c
Compare
TheSafo
force-pushed
the
jsaf/throttle-error-change
branch
from
242e45f to
413e3a8
Compare
blt
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test-only PR that introduces some tests as an intermediate step before changing deserialization of LoadProfile and BytesThrottleConfig. This way it's easier to verify in #1675 that we didn't break existing configs.