Modify throttle errors to not assume capacity issue #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TheSafo
changed the title
This was referenced Jan 6, 2026
Draft
TheSafo
force-pushed
the
jsaf/throttle-error-change
branch
from
891a604 to
242e45f
Compare
TheSafo
force-pushed
the
graphite-base/1679
branch
from
7a819ad to
92a7bd0
Compare
TheSafo
changed the base branch from
graphite-base/1679
to
jsaf/resize-blocks
TheSafo
force-pushed
the
jsaf/resize-blocks
branch
from
92a7bd0 to
f4e7959
Compare
TheSafo
force-pushed
the
jsaf/throttle-error-change
branch
from
242e45f to
413e3a8
Compare
blt
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to throttler error handling in the generators so that callers don't assume a capacity issue.
This way, callers don't need to calculate total bytes before the error, which is less applicable for block-based throttling in the follow up change: #1675
https://datadoghq.atlassian.net/browse/EPIN-2527