Skip to content

Add a test for search_string with spaces #22445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NouemanKHAL wants to merge 3 commits into
base: master
Choose a base branch
from
+23 −3
Open

Add a test for search_string with spaces #22445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaebd92
add a test for search_string containing spaces
NouemanKHAL Jan 28, 2026
5f1ad66
run check in the new test, and add more test
NouemanKHAL Jan 29, 2026
70285ae
apply suggestion: remove unnecessary assertion
NouemanKHAL Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions process/tests/test_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,16 @@ def __exit__(self, type, value, traceback):


class NamedMockProcess(object):
def __init__(self, name):
self.pid = None
def __init__(self, name, pid=None, cmdline=None):
self.pid = pid
self._name = name
self._cmdline = cmdline or []

def name(self):
return self._name

def cmdline(self):
return []
return self._cmdline


def get_psutil_proc():
Expand Down Expand Up @@ -237,6 +238,25 @@ def test_check_missing_process(aggregator, dd_run_check, caplog):
assert "Unable to find process named ['fooprocess', '/usr/bin/foo'] among processes" in caplog.text


def test_check_missing_process_with_spaces(aggregator, dd_run_check, caplog):
caplog.set_level(logging.DEBUG)
instance = {'name': 'foo', 'search_string': ['foo bar process', '/usr/bin/foo test'], 'exact_match': False}
process = ProcessCheck(common.CHECK_NAME, {}, [instance])
dd_run_check(process)
aggregator.assert_service_check('process.up', count=1, status=process.CRITICAL)
assert "Unable to find process named ['foo bar process', '/usr/bin/foo test'] among processes" in caplog.text


@patch('psutil.process_iter', return_value=[NamedMockProcess("foo", pid=123, cmdline=["foo", "bar", "--baz"])])
def test_search_string_with_spaces(mock_process_iter, aggregator, dd_run_check):
instance = {'name': 'foo', 'search_string': ['foo bar --baz'], 'exact_match': False}
process = ProcessCheck(common.CHECK_NAME, {}, [instance])
dd_run_check(process)
expected_tags = generate_expected_tags(instance)
aggregator.assert_metric('system.processes.number', value=1, tags=expected_tags)
aggregator.assert_service_check('process.up', count=1, tags=expected_tags + ['process:foo'])


@pytest.mark.parametrize("oneshot", [True, False])
def test_check_real_process(aggregator, dd_run_check, oneshot):
"Check that we detect python running (at least this process)"
Expand Down
Loading