Add a test for search_string with spaces #22445
Open
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
sarah-witt
reviewed
Jan 28, 2026
| instance = {'name': 'foo', 'search_string': ['foo bar'], 'exact_match': False} | ||
| process = ProcessCheck(common.CHECK_NAME, {}, [instance]) | ||
| pids = process.find_pids(instance['name'], instance['search_string'], instance['exact_match']) | ||
| assert pids == {123} |
Contributor
There was a problem hiding this comment.
nit: could we run the check rather than find_pids and assert the metrics emitted? That way the test will still work even if we refactor out find_pids?
Contributor
There was a problem hiding this comment.
looks great!! i think you can remove line 254 and 255 now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a test to verify the use case where the
search_stringproperty contains spaces.Motivation
Our current implementation already support this use case, it's good to add to protect it from regressions and to serve as documentation.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged