Skip to content

upgradations for latest rxjs imports #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prntcena wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgradations for latest rxjs imports #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AngularApp/src/app/shared/employee.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
import { Injectable } from '@angular/core';
import { HttpClient } from '@angular/common/http';
//changes for latest rxjs imports as previous were not working
/*
import { Observable } from 'rxjs/Observable';
import 'rxjs/add/operator/map';
import 'rxjs/add/operator/toPromise';
*/
import { Observable } from 'rxjs';

import { map } from 'rxjs/operators';
import { toPromise } from 'rxjs/operators';

import { Employee } from './employee.model';

Comment on lines 1 to 16
Copy link

@Jithendra-k Jithendra-k Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest version of rxjs, we dont need to import toPromise.js since it is included in the Observable itself.

Copy link

@Buddhimav Buddhimav Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not working properly. when I insert this "import { toPromise } from 'rxjs/operators';" , toPromise has been underlined and
without these line " import { Observable } from 'rxjs';

import { map } from 'rxjs/operators';
import { toPromise } from 'rxjs/operators';"

or within these lines cannot load the web page.

Expand Down