upgradations for latest rxjs imports #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followed your tutorial and faced issue in " module not imported "rxjs"" . Got this fixed by these changes.
Jithendra-k
reviewed
Oct 22, 2020
Comment on lines
1
to
16
| import { Injectable } from '@angular/core'; | ||
| import { HttpClient } from '@angular/common/http'; | ||
| //changes for latest rxjs imports as previous were not working | ||
| /* | ||
| import { Observable } from 'rxjs/Observable'; | ||
| import 'rxjs/add/operator/map'; | ||
| import 'rxjs/add/operator/toPromise'; | ||
| */ | ||
| import { Observable } from 'rxjs'; | ||
|
|
||
| import { map } from 'rxjs/operators'; | ||
| import { toPromise } from 'rxjs/operators'; | ||
|
|
||
| import { Employee } from './employee.model'; | ||
|
|
There was a problem hiding this comment.
In the latest version of rxjs, we dont need to import toPromise.js since it is included in the Observable itself.
There was a problem hiding this comment.
still not working properly. when I insert this "import { toPromise } from 'rxjs/operators';" , toPromise has been underlined and
without these line " import { Observable } from 'rxjs';
import { map } from 'rxjs/operators';
import { toPromise } from 'rxjs/operators';"
or within these lines cannot load the web page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followed your tutorial and faced issue in " module not imported "rxjs"" . Got this fixed by these changes.