[WIP] Port to linux savestates efficiency v2#60
Draft
DoorDasher81 wants to merge 19 commits intoBrawlback-Team:savestates-efficiency-v2from
Draft
[WIP] Port to linux savestates efficiency v2#60DoorDasher81 wants to merge 19 commits intoBrawlback-Team:savestates-efficiency-v2from
DoorDasher81 wants to merge 19 commits intoBrawlback-Team:savestates-efficiency-v2from
Conversation
added 13 commits
February 15, 2025 06:48
DoorDasher81
commented
Feb 14, 2025
| #include <Common/MemoryUtil.h> | ||
|
|
||
| #ifdef __linux__ | ||
| #include <mm_malloc.h> // _mm_alloc, _mm_free |
added 6 commits
February 15, 2025 21:13
WhiteTPoison
force-pushed
the
savestates-efficiency-v2
branch
from
d3953fb to
ac227de
Compare
KittenBrix
reviewed
Jun 26, 2025
| #ifdef _WIN32 | ||
| DWORD dw = GetLastError(); | ||
| ERROR_LOG_FMT(BRAWLBACK, "WRITTEN PAGE WRITE FAILED DUE TO A FAILURE ({}) TO WRITE PROTECT. THE REASON IS: {}\n", result, dw); | ||
| #elif __linux__ |
There was a problem hiding this comment.
non-blocker safer to use #elif defined(__linux__) if you can't guarantee we're populating linux. Additionally you can use #elif defined(__APPLE__) for mac specific check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port savestates-efficiency-v2 branch.
build
personal todos
test match, game
add static TODO assertions for mac