Fix fmtlib v11 compile-time errors#61
Open
SilverMight wants to merge 3 commits intoBrawlback-Team:savestates-efficiency-v2from
Open
Fix fmtlib v11 compile-time errors#61SilverMight wants to merge 3 commits intoBrawlback-Team:savestates-efficiency-v2from
SilverMight wants to merge 3 commits intoBrawlback-Team:savestates-efficiency-v2from
Conversation
WhiteTPoison
force-pushed
the
savestates-efficiency-v2
branch
from
d3953fb to
ac227de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compile-time errors when compiling with fmtlib >= v11.0. This fixes compilation on systems like Arch, which have a newer fmt version, since the system fmt is used by default.
Two of the patches are from upstream Dolphin (dolphin-emu#13262). The linked PR contains more info on those changes.
Another patch was added to
EXIBrawlback.cppto fix an incorrect format string causing a compile-time error.This was tested with my system's fmt v11.1.4, and the bundled fmt v10.2.1 by using
USE_SYSTEM_FMT=off.Note I only really tested these changes by cherry-picking them out to
master, since this branch can't compile on Linux currently. I also tested compilation on the open PR #60 that can currently compile on Linux.