Skip to content

Conversation

@ahwm
Copy link
Collaborator

@ahwm ahwm commented Oct 28, 2024

No description provided.

@ahwm ahwm marked this pull request as ready for review October 28, 2024 22:03
@ahwm
Copy link
Collaborator Author

ahwm commented Oct 28, 2024

If approved, @BrandonPotter will need to update the repository settings (fix what's required) and add a repository secret for NuGet.

Also of note: committing and pushing to "master" requires a review from one of us already so I thought it made sense to go ahead and push to NuGet here.

I also realize that this current implementation will attempt to push to NuGet all three times once a pull request is merged. One option is to add OS to the if on that step. The other option is to have a secondary "release" workflow that only pushes to NuGet when running on a tag. I have this scenario on one or two of my own personal repos and I'm happy to duplicate that here.

@ahwm ahwm requested a review from flytzen October 28, 2024 22:56
@ahwm
Copy link
Collaborator Author

ahwm commented Nov 13, 2024

@flytzen ?

Copy link
Collaborator

@flytzen flytzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Sorry for the delay.

@ahwm
Copy link
Collaborator Author

ahwm commented Nov 13, 2024

pinged @BrandonPotter to make the admin updates so we can merge.

@BrandonPotter
Copy link
Owner

Thanks for this! Checking on the NG key..

@BrandonPotter
Copy link
Owner

NUGET_KEY added to repository secrets

@ahwm
Copy link
Collaborator Author

ahwm commented Nov 13, 2024

NUGET_KEY added to repository secrets

Great. Can you also update the merge requirements so the currently required status isn't? Or if you're okay granting me permissions I can fix that.

@ahwm
Copy link
Collaborator Author

ahwm commented Sep 17, 2025

This has been in limbo for almost a year. @BrandonPotter any chance of updating the required checks or granting admin privileges on the repo (even just temporarily) so I can take care of that?

image

@ahwm ahwm merged commit 58cbddb into master Nov 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants