Add SetupUrl to the SetupCode class #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm. Tests were passing locally. Quick look seems like it's failing for dotnet versioning. I'll take a closer look later, see if I've inadvertently screwed something up. |
Collaborator
Issues discussed here: #239 (comment) with additional changes in #242 to account for other issues with AzDo. But with .NET 6 now fully out of support, .NET 9 out, and .NET 10 on the way we need to adjust our test TFMs anyway. |
Contributor
Author
|
@ahwm I've made a couple of changes to the pipeline to install the necessary dotnet versions (6 and 7). This has allowed the tests to run and pass successfully. |
ahwm
approved these changes
Sep 22, 2025
Collaborator
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #253, this change adds a new property to the
SetupCodeclass:SetupUrl- This url contains the rawotpauth://url for the setup.This value is identical to the url encoded within the QR Code, and can be used to provide a clickable link to set up, for users who are attempting to set up the authenticator on the device they are viewing the page.