bribe platform abstraction, add stakeDAO #225
Conversation
process explicit partner pools
|
test run: #232 (comment) |
|
the stakedao |
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
Very clean abstraction of the bribing markets we intent to support. Added general comments for minor tweaks.
|
|
||
| gauge_address = Web3.to_checksum_address(row["target"]) | ||
| chain_name = self._gauge_to_chain_cache.get(gauge_address.lower(), "mainnet") | ||
| chain_id = AddrBook.chain_ids_by_name.get(chain_name) |
There was a problem hiding this comment.
No error handling if chain_id can't be mapped, then it's None
There was a problem hiding this comment.
ya if chain name/id cant be resolved then imo an explicit error should be thrown. also i dont think the chain name should default to mainnet. adjusted in e8231ba
| """ | ||
| pass | ||
|
|
||
| @abstractmethod |
There was a problem hiding this comment.
Questioning if this should be an abstractmethod as only HH uses approvals, worth making this optional?
There was a problem hiding this comment.
good call. ya should be optional so other bribe platforms dont have to define the method if not needed. updated in f4a0454
|
failing test is from ezkl in the partner config. can ignore here. fixed in #236 |
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
LGTM, let's get test runs out with ezkl in effect
#219
market_overrideand "split" as a newvoting_pool_override(for the special case of stakeDAO where we want balancer bribes to be deposited on stakedao, but have aura bribes on hh)also re-added functionality for partners in partner config to define a list of pools to process