Skip to content

[Packaging] Optimize MSI upgrade performance by simplifying file replacement logic #32678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangzelin007 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[Packaging] Optimize MSI upgrade performance by simplifying file replacement logic #32678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73446bd
{Packaging} Optimize MSI upgrade performance with REINSTALLMODE=amus
wangzelin007 Jan 19, 2026
3f321d4
update
wangzelin007 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build_scripts/windows/Product.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
<UpgradeVersion Property="WIX_DOWNGRADE_DETECTED" Minimum="$(var.ProductVersion)" IncludeMinimum="no" OnlyDetect="yes" />
</Upgrade>
<InstallExecuteSequence>
<RemoveExistingProducts After="InstallExecute" />
<!-- RemoveExistingProducts runs BEFORE InstallInitialize to completely remove old version first. -->
<RemoveExistingProducts Before="InstallInitialize" />
</InstallExecuteSequence>

<!-- New product architectures should upgrade the original x86 product - even of the same version. -->
Expand All @@ -74,6 +75,9 @@
<Property Id="MSIFASTINSTALL" Value="7" />
<Property Id="ApplicationFolderName" Value="Microsoft SDKs\Azure" />
<Property Id="WixAppFolder" Value="WixPerMachineFolder" />

<!-- Force reinstall of all files during upgrade -->
<SetProperty Id="REINSTALLMODE" Value="amus" Before="CostFinalize" Sequence="both">WIX_UPGRADE_DETECTED</SetProperty>

<Feature Id="ProductFeature"
Title="Microsoft Azure CLI"
Expand Down